Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: src/bootstrapper.cc

Issue 1517673002: Fix Object.prototype.toString.call(proxy) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index a5a1da3bc388c93da101a88aca261caccebdddff..ebb3d05d490251547b78e3d3425ade9f26952b19 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -2240,6 +2240,7 @@ void Genesis::InstallJSProxyMaps() {
Handle<Map> proxy_callable_map = Map::Copy(proxy_map, "callable Proxy");
proxy_callable_map->set_is_callable();
native_context()->set_proxy_callable_map(*proxy_callable_map);
+ proxy_callable_map->SetConstructor(native_context()->function_function());
Handle<Map> proxy_constructor_map =
Map::Copy(proxy_callable_map, "constructor Proxy");
@@ -2261,8 +2262,8 @@ void Genesis::InitializeGlobal_harmony_proxies() {
Handle<String> name = factory->Proxy_string();
Handle<Code> code(isolate->builtins()->ProxyConstructor());
- Handle<JSFunction> proxy_function =
- factory->NewFunction(isolate->proxy_function_map(), name, code);
+ Handle<JSFunction> proxy_function = factory->NewFunction(
+ isolate->proxy_function_map(), factory->Object_string(), code);
JSFunction::SetInitialMap(proxy_function,
Handle<Map>(native_context()->proxy_map(), isolate),
@@ -2274,7 +2275,7 @@ void Genesis::InitializeGlobal_harmony_proxies() {
proxy_function->shared()->set_length(2);
native_context()->set_proxy_function(*proxy_function);
- InstallFunction(global, name, proxy_function, name);
+ InstallFunction(global, name, proxy_function, factory->Object_string());
}

Powered by Google App Engine
This is Rietveld 408576698