Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: src/crankshaft/ppc/lithium-codegen-ppc.cc

Issue 1517673002: Fix Object.prototype.toString.call(proxy) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/crankshaft/ppc/lithium-codegen-ppc.cc
diff --git a/src/crankshaft/ppc/lithium-codegen-ppc.cc b/src/crankshaft/ppc/lithium-codegen-ppc.cc
index d1e2c223e18c66a8bdd6e6452443ae11b2085732..6e260e8628f01109361b872f17cdf0fa23401eaf 100644
--- a/src/crankshaft/ppc/lithium-codegen-ppc.cc
+++ b/src/crankshaft/ppc/lithium-codegen-ppc.cc
@@ -2614,14 +2614,11 @@ void LCodeGen::EmitClassOfTest(Label* is_true, Label* is_false,
// Assuming the following assertions, we can use the same compares to test
// for both being a function type and being in the object type range.
STATIC_ASSERT(NUM_OF_CALLABLE_SPEC_OBJECT_TYPES == 2);
- STATIC_ASSERT(FIRST_NONCALLABLE_SPEC_OBJECT_TYPE ==
- FIRST_JS_RECEIVER_TYPE + 1);
STATIC_ASSERT(LAST_NONCALLABLE_SPEC_OBJECT_TYPE ==
LAST_JS_RECEIVER_TYPE - 1);
STATIC_ASSERT(LAST_JS_RECEIVER_TYPE == LAST_TYPE);
__ CompareObjectType(input, temp, temp2, FIRST_JS_RECEIVER_TYPE);
__ blt(is_false);
- __ beq(is_true);
__ cmpi(temp2, Operand(LAST_JS_RECEIVER_TYPE));
__ beq(is_true);
} else {
@@ -2629,9 +2626,9 @@ void LCodeGen::EmitClassOfTest(Label* is_true, Label* is_false,
// actual type and do a signed compare with the width of the type range.
__ LoadP(temp, FieldMemOperand(input, HeapObject::kMapOffset));
__ lbz(temp2, FieldMemOperand(temp, Map::kInstanceTypeOffset));
- __ subi(temp2, temp2, Operand(FIRST_NONCALLABLE_SPEC_OBJECT_TYPE));
+ __ subi(temp2, temp2, Operand(FIRST_JS_RECEIVER_TYPE));
__ cmpi(temp2, Operand(LAST_NONCALLABLE_SPEC_OBJECT_TYPE -
- FIRST_NONCALLABLE_SPEC_OBJECT_TYPE));
+ FIRST_JS_RECEIVER_TYPE));
__ bgt(is_false);
}

Powered by Google App Engine
This is Rietveld 408576698