Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1517653003: Fix BUILD.gn to load the correct V8 snapshot configuration (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Fix BUILD.gn to load the correct V8 snapshot configuration BUG=pdfium:299 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1520443002 . (cherry picked from commit 94edf0c37d1ee6a03697375b9e227071ff2ee69d) Committed: https://pdfium.googlesource.com/pdfium/+/7ed503d2dbe0b51550f85df1c47990d12eb68f59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M BUILD.gn View 4 chunks +4 lines, -0 lines 0 comments Download
M samples/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-12-10 13:38:03 UTC) #1
jochen (gone - plz use gerrit)
Committed patchset #1 (id:1) manually as 7ed503d2dbe0b51550f85df1c47990d12eb68f59 (presubmit successful).
5 years ago (2015-12-10 13:38:11 UTC) #3
Tom Sepez
5 years ago (2015-12-10 17:45:29 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698