Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 1520443002: Fix BUILD.gn to load the correct V8 snapshot configuration (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
kcc2
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix BUILD.gn to load the correct V8 snapshot configuration BUG=pdfium:299 R=kcc@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/94edf0c37d1ee6a03697375b9e227071ff2ee69d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M BUILD.gn View 4 chunks +4 lines, -0 lines 0 comments Download
M samples/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-12-10 10:43:18 UTC) #1
kcc2
lgtm
5 years ago (2015-12-10 10:44:45 UTC) #2
jochen (gone - plz use gerrit)
5 years ago (2015-12-10 10:45:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94edf0c37d1ee6a03697375b9e227071ff2ee69d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698