Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: samples/BUILD.gn

Issue 1517653003: Fix BUILD.gn to load the correct V8 snapshot configuration (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 PDFium Authors. All rights reserved. 1 # Copyright 2014 PDFium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sanitizers/sanitizers.gni") 5 import("//build/config/sanitizers/sanitizers.gni")
6 import("//build_overrides/v8.gni")
6 import("../pdfium.gni") 7 import("../pdfium.gni")
7 8
8 group("samples") { 9 group("samples") {
9 testonly = true 10 testonly = true
10 deps = [ 11 deps = [
11 ":pdfium_test", 12 ":pdfium_test",
12 ":pdfium_diff", 13 ":pdfium_diff",
13 ] 14 ]
14 } 15 }
15 16
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 ] 48 ]
48 if (!pdf_enable_xfa) { 49 if (!pdf_enable_xfa) {
49 deps += [ "../third_party:fx_lpng" ] 50 deps += [ "../third_party:fx_lpng" ]
50 } 51 }
51 if (pdf_enable_v8) { 52 if (pdf_enable_v8) {
52 deps += [ "//v8:v8_libplatform" ] 53 deps += [ "//v8:v8_libplatform" ]
53 include_dirs = [ 54 include_dirs = [
54 "//v8", 55 "//v8",
55 "//v8/include", 56 "//v8/include",
56 ] 57 ]
58 configs += [ "//v8:external_startup_data" ]
57 } 59 }
58 configs += [ ":pdfium_samples_config" ] 60 configs += [ ":pdfium_samples_config" ]
59 } 61 }
60 62
61 executable("pdfium_diff") { 63 executable("pdfium_diff") {
62 testonly = true 64 testonly = true
63 sources = [ 65 sources = [
64 "image_diff.cc", 66 "image_diff.cc",
65 "image_diff_png.cc", 67 "image_diff_png.cc",
66 "image_diff_png.h", 68 "image_diff_png.h",
67 ] 69 ]
68 deps = [ 70 deps = [
69 "//build/config/sanitizers:deps", 71 "//build/config/sanitizers:deps",
70 "//third_party/pdfium", 72 "//third_party/pdfium",
71 ] 73 ]
72 if (!pdf_enable_xfa) { 74 if (!pdf_enable_xfa) {
73 deps += [ "../third_party:fx_lpng" ] 75 deps += [ "../third_party:fx_lpng" ]
74 } 76 }
75 configs -= [ "//build/config/compiler:chromium_code" ] 77 configs -= [ "//build/config/compiler:chromium_code" ]
76 configs += [ 78 configs += [
77 ":pdfium_samples_config", 79 ":pdfium_samples_config",
78 "//build/config/compiler:no_chromium_code", 80 "//build/config/compiler:no_chromium_code",
79 ] 81 ]
80 } 82 }
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698