Move distance field text positioning into GrTextUtils

Move distance field text positioning into GrTextUtils

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1521633002

Committed: https://skia.googlesource.com/skia/+/0d2199b3db21e1f22cf328ca090aa0c8abc9067f

[joshualitt, 2015-12-11 19:39:20]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, jvanverth@google.com

[joshualitt, 2015-12-11 19:39:21]

This CL is mostly just a code move, plus some tweaks so that
CanDrawAsDistanceFields can be static.

[joshualitt, 2016-01-19 14:48:53]

On 2015/12/11 19:39:21, joshualitt wrote:
> This CL is mostly just a code move, plus some tweaks so that
> CanDrawAsDistanceFields can be static.

pinging this, its mostly just a code move

[joshua.litt, 2016-01-19 14:54:22]

Description was changed from

==========
Move distance field text positioning into GrTextUtils

BUG=skia:
==========

to

==========
Move distance field text positioning into GrTextUtils

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-19 15:01:19]

I defer to Jim.

[jvanverth1, 2016-01-19 17:32:47]

The rest looks fine.

https://codereview.chromium.org/1521633002/diff/60001/src/gpu/text/GrTextUtils.h
File src/gpu/text/GrTextUtils.h (right):

https://codereview.chromium.org/1521633002/diff/60001/src/gpu/text/GrTextUtil...
src/gpu/text/GrTextUtils.h:56: static void DrawDfText(GrAtlasTextBlob* blob, int
runIndex,
This doesn't strike me as the correct camel case: DF is an abbreviation. It was
drawDFText before.

[joshualitt, 2016-01-19 21:09:18]

On 2016/01/19 17:32:47, jvanverth1 wrote:
> The rest looks fine.
> 
>
https://codereview.chromium.org/1521633002/diff/60001/src/gpu/text/GrTextUtils.h
> File src/gpu/text/GrTextUtils.h (right):
> 
>
https://codereview.chromium.org/1521633002/diff/60001/src/gpu/text/GrTextUtil...
> src/gpu/text/GrTextUtils.h:56: static void DrawDfText(GrAtlasTextBlob* blob,
int
> runIndex,
> This doesn't strike me as the correct camel case: DF is an abbreviation. It
was
> drawDFText before.

feedback incorporated

[jvanverth1, 2016-01-20 13:43:48]

lgtm

[joshualitt, 2016-01-20 14:23:04]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2016-01-20 14:23:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1521633002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1521633002/80001

[commit-bot: I haz the power, 2016-01-20 14:36:12]

Description was changed from

==========
Move distance field text positioning into GrTextUtils

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Move distance field text positioning into GrTextUtils

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/0d2199b3db21e1f22cf328ca090aa0c8abc9067f
==========

[commit-bot: I haz the power, 2016-01-20 14:36:13]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/0d2199b3db21e1f22cf328ca090aa0c8abc9067f