Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: src/messages.h

Issue 1516843002: [proxy] fixing harmony/proxy.js tests and improving error messages + some drive-by fixes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: WIP fix protoype walks with access checks Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/messages.h
diff --git a/src/messages.h b/src/messages.h
index b6e22bc096b75a5e91bc51a3f4423828f2ea7a90..b082f10b32b997fd65086427e1d53f6adedc4079 100644
--- a/src/messages.h
+++ b/src/messages.h
@@ -189,7 +189,6 @@ class CallSite {
"Trap 'deleteProperty' returned true but property '%' is not configurable" \
" in the proxy target") \
T(ProxyHandlerNonObject, "Cannot create proxy with non-object as handler") \
- T(ProxyHandlerReturned, "Proxy handler % returned % from '%' trap") \
T(ProxyHandlerTrapMissing, "Proxy handler % has no '%' trap") \
T(ProxyHandlerTrapMustBeCallable, \
"Proxy handler % has non-callable '%' trap") \
@@ -214,7 +213,16 @@ class CallSite {
"Construct trap must return Object, but got ''%s'.") \
T(ProxyTrapFunctionExpected, \
"Proxy.createFunction called with non-function for '%' trap") \
- T(ProxyTrapResultMustInclude, "Trap result must include %.") \
+ T(ProxyTrapOwnKeysResultMustInclude, \
+ "Result of trap 'ownKeys' must include '%'.") \
+ T(ProxyTrapReturned, "Proxy handler % returned % from '%' trap") \
+ T(ProxyTrapReturnedFalseish, \
+ "Proxy handler % returned false value '%' from '%' trap") \
+ T(ProxyTrapReturnedNonObject, \
+ "Proxy handler % returned '%' from '%' trap instead of an Object") \
+ T(ProxyTrapDescriptorNonConfigurable, \
+ "Proxy %s trap returned non-configurable PropertyDescriptor for property " \
+ "'%' even though the property on the Proxy target is configurable") \
T(ProxyTrapViolatesInvariant, \
"Result of trap '%' is inconsistent with proxy's target") \
T(RedefineDisallowed, "Cannot redefine property: %") \

Powered by Google App Engine
This is Rietveld 408576698