[proxy] fixing harmony/proxy.js tests and improving error messages + some drive-by fixes

src/messages.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The infrastructure used for (localized) message reporting in V8.
 //
 // Note: there's a big unresolved issue about ownership of the data
 // structures used by this framework.
 
 #ifndef V8_MESSAGES_H_
@@ skipping 171 matching lines @@
   T(PropertyDescObject, "Property description must be an object: %")           \
   T(PropertyNotFunction,                                                       \
     "'%' returned for property '%' of object '%' is not a function")           \
   T(ProtoObjectOrNull, "Object prototype may only be an Object or null: %")    \
   T(PrototypeParentNotAnObject,                                                \
     "Class extends value does not have valid prototype property %")            \
   T(ProxyDeletePropertyViolatesInvariant,                                      \
     "Trap 'deleteProperty' returned true but property '%' is not configurable" \
     " in the proxy target")                                                    \
   T(ProxyHandlerNonObject, "Cannot create proxy with non-object as handler")   \
-  T(ProxyHandlerReturned, "Proxy handler % returned % from '%' trap")          \
   T(ProxyHandlerTrapMissing, "Proxy handler % has no '%' trap")                \
   T(ProxyHandlerTrapMustBeCallable,                                            \
     "Proxy handler % has non-callable '%' trap")                               \
   T(ProxySetPrototypeFailed,                                                   \
     "Proxy handler returned false when setting prototype '%'")                 \
   T(ProxyNonObjectPropNames, "Trap '%' returned non-object %")                 \
   T(ProxyPreventExtensionsViolatesInvariant,                                   \
     "Trap 'preventExtensions' returned true but the proxy's target is "        \
     "extensible")                                                              \
   T(ProxyPropNotConfigurable,                                                  \
     "Proxy handler % returned non-configurable descriptor for property '%' "   \
     "from '%' trap")                                                           \
   T(ProxyRepeatedPropName, "Trap '%' returned repeated property name '%'")     \
   T(ProxyHandlerOrTargetRevoked,                                               \
     "Cannot create proxy with a revoked proxy as handler or target")           \
   T(ProxyRevoked, "Cannot perform '%' on a proxy that has been revoked")       \
   T(ProxyTargetNotExtensible, "Proxy target is not extensible")                \
   T(ProxyTargetNonObject, "Proxy target is non-object")                        \
   T(ProxyTargetPropNotConfigurable,                                            \
     "Proxy target property '%' is not configurable")                           \
   T(ProxyTrapConstructMustReturnObject,                                        \
     "Construct trap must return Object, but got ''%s'.")                       \
   T(ProxyTrapFunctionExpected,                                                 \
     "Proxy.createFunction called with non-function for '%' trap")              \
-  T(ProxyTrapResultMustInclude, "Trap result must include %.")                 \
+  T(ProxyTrapOwnKeysResultMustInclude,                                         \
+    "Result of trap 'ownKeys' must include '%'.")                              \
+  T(ProxyTrapReturned, "Proxy handler % returned % from '%' trap")             \
+  T(ProxyTrapReturnedFalseish,                                                 \
+    "Proxy handler % returned false value '%' from '%' trap")                  \
+  T(ProxyTrapReturnedNonObject,                                                \
+    "Proxy handler % returned '%' from '%' trap instead of an Object")         \
+  T(ProxyTrapDescriptorNonConfigurable,                                        \
+    "Proxy %s trap returned non-configurable PropertyDescriptor for property " \
+    "'%' even though the property on the Proxy target is configurable")        \
   T(ProxyTrapViolatesInvariant,                                                \
     "Result of trap '%' is inconsistent with proxy's target")                  \
   T(RedefineDisallowed, "Cannot redefine property: %")                         \
   T(RedefineExternalArray,                                                     \
     "Cannot redefine a property of an object with external array elements")    \
   T(ReduceNoInitial, "Reduce of empty array with no initial value")            \
   T(RegExpFlags,                                                               \
     "Cannot supply flags when constructing one RegExp from another")           \
   T(RegExpNonObject, "% getter called on non-object %")                        \
   T(RegExpNonRegExp, "% getter called on non-RegExp object")                   \
@@ skipping 257 matching lines @@
   static Handle<String> GetMessage(Isolate* isolate, Handle<Object> data);
   static base::SmartArrayPointer<char> GetLocalizedMessage(Isolate* isolate,
                                                            Handle<Object> data);
 };
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_MESSAGES_H_