Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: src/js/v8natives.js

Issue 1516843002: [proxy] fixing harmony/proxy.js tests and improving error messages + some drive-by fixes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: WIP fix protoype walks with access checks Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/js/v8natives.js
diff --git a/src/js/v8natives.js b/src/js/v8natives.js
index 1ae6e4832029b3354503b2711064290cb3fa85d0..b068ebf9094408b5449bfcd49d8026a5356ac666 100644
--- a/src/js/v8natives.js
+++ b/src/js/v8natives.js
@@ -569,7 +569,7 @@ function DefineProxyProperty(obj, p, attributes, should_throw) {
var result = CallTrap2(handler, "defineProperty", UNDEFINED, p, attributes);
if (!result) {
if (should_throw) {
- throw MakeTypeError(kProxyHandlerReturned,
+ throw MakeTypeError(kProxyTrapReturned,
handler, "false", "defineProperty");
} else {
return false;

Powered by Google App Engine
This is Rietveld 408576698