Remove deprecation messages for no-ops that are left in the specs

Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

Take the opportunity to remove the detach() calls from a few tests where
it does nothing anyway. Remove detach-range-during-deletecontents.html
as that was testing specifically detach() which cannot be relevant now
that it is a no-op. Some of the range-* tests are left untouched as they
explicitly call out that detach() is a no-op in comments.

These are the reviews where these deprecation messages were added:
https://codereview.chromium.org/256013002
https://codereview.chromium.org/252783002
https://codereview.chromium.org/901623002

BUG=568218
R=rbyers@chromium.org

Committed: https://crrev.com/19739b85c91bc1f7e72565824b14238666d4caf4
Cr-Commit-Position: refs/heads/master@{#364745}

[philipj_slow, 2015-12-09 15:27:41]

PTAL. Test expectations need updating, but I didn't want to spend time on that
if the idea won't fly.

[Rick Byers, 2015-12-09 20:18:02]

Description was changed from

==========
Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

R=rbyers@chromium.org
==========

to

==========
Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

BUG=568218
R=rbyers@chromium.org
==========

[Rick Byers, 2015-12-09 20:20:31]

I (obviously) support this sort of thing in general.  Added reference to
BUG=568218 to track the larger issue / blink-dev discussion.

But I don't have the context on these specific APIs.  Can you provide links to
the discussion for them and at least cc whoever added the deprecation warning in
the first place?

[philipj_slow, 2015-12-09 22:18:54]

Description was changed from

==========
Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

BUG=568218
R=rbyers@chromium.org
==========

to

==========
Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

These are the reviews where these deprecation messages were added:
https://codereview.chromium.org/256013002
https://codereview.chromium.org/252783002
https://codereview.chromium.org/901623002

BUG=568218
R=rbyers@chromium.org
==========

[philipj_slow, 2015-12-09 22:19:37]

On 2015/12/09 20:20:31, Rick Byers wrote:
> I (obviously) support this sort of thing in general.  Added reference to
> BUG=568218 to track the larger issue / blink-dev discussion.
> 
> But I don't have the context on these specific APIs.  Can you provide links to
> the discussion for them and at least cc whoever added the deprecation warning
in
> the first place?

I've listed the reviews where these were added in the description. Turns out I
approved of the SVG ones at the time :)

[philipj_slow, 2015-12-10 18:51:20]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-10 18:52:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1516553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1516553002/20001

[commit-bot: I haz the power, 2015-12-10 21:46:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 21:46:31]

Dry run: This issue passed the CQ dry run.

[Rick Byers, 2015-12-11 15:02:44]

LGTM, sorry for the delay

[philipj_slow, 2015-12-11 15:06:53]

On 2015/12/11 15:02:44, Rick Byers wrote:
> LGTM, sorry for the delay

I realize this leaves the SVG no-op methods entirely untested, which is why I
insisted on adding this test previously. I'll revive it in another form to still
have that coverage.

[Rick Byers, 2015-12-11 15:26:50]

On 2015/12/11 15:06:53, philipj wrote:
> On 2015/12/11 15:02:44, Rick Byers wrote:
> > LGTM, sorry for the delay
> 
> I realize this leaves the SVG no-op methods entirely untested, which is why I
> insisted on adding this test previously. I'll revive it in another form to
still
> have that coverage.

How do you test that a method is a no-op?  Just that it exists and doesn't throw
when called via expected syntax?  That sounds find to me.  I'd also be OK
depending just on the webexposed tests to verify the APIs existence and a
comment in the code saying the methods intentionally do nothing.

[philipj_slow, 2015-12-11 15:26:53]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-11 15:27:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1516553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1516553002/40001

[philipj_slow, 2015-12-11 15:28:16]

Description was changed from

==========
Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

These are the reviews where these deprecation messages were added:
https://codereview.chromium.org/256013002
https://codereview.chromium.org/252783002
https://codereview.chromium.org/901623002

BUG=568218
R=rbyers@chromium.org
==========

to

==========
Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

Take the opportunity to remove the detach() call from a few tests where
it does nothing anyway. Remove detach-range-during-deletecontents.html
as that was testing specifically detach() which cannot be relevant now
that it is a no-op. Some of the range-* are left untouched as they
explicitly call out that detach() is a no-op in comments.

These are the reviews where these deprecation messages were added:
https://codereview.chromium.org/256013002
https://codereview.chromium.org/252783002
https://codereview.chromium.org/901623002

BUG=568218
R=rbyers@chromium.org
==========

[philipj_slow, 2015-12-11 15:28:30]

Description was changed from

==========
Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

Take the opportunity to remove the detach() call from a few tests where
it does nothing anyway. Remove detach-range-during-deletecontents.html
as that was testing specifically detach() which cannot be relevant now
that it is a no-op. Some of the range-* are left untouched as they
explicitly call out that detach() is a no-op in comments.

These are the reviews where these deprecation messages were added:
https://codereview.chromium.org/256013002
https://codereview.chromium.org/252783002
https://codereview.chromium.org/901623002

BUG=568218
R=rbyers@chromium.org
==========

to

==========
Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

Take the opportunity to remove the detach() calls from a few tests where
it does nothing anyway. Remove detach-range-during-deletecontents.html
as that was testing specifically detach() which cannot be relevant now
that it is a no-op. Some of the range-* are left untouched as they
explicitly call out that detach() is a no-op in comments.

These are the reviews where these deprecation messages were added:
https://codereview.chromium.org/256013002
https://codereview.chromium.org/252783002
https://codereview.chromium.org/901623002

BUG=568218
R=rbyers@chromium.org
==========

[philipj_slow, 2015-12-11 15:28:54]

Description was changed from

==========
Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

Take the opportunity to remove the detach() calls from a few tests where
it does nothing anyway. Remove detach-range-during-deletecontents.html
as that was testing specifically detach() which cannot be relevant now
that it is a no-op. Some of the range-* are left untouched as they
explicitly call out that detach() is a no-op in comments.

These are the reviews where these deprecation messages were added:
https://codereview.chromium.org/256013002
https://codereview.chromium.org/252783002
https://codereview.chromium.org/901623002

BUG=568218
R=rbyers@chromium.org
==========

to

==========
Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

Take the opportunity to remove the detach() calls from a few tests where
it does nothing anyway. Remove detach-range-during-deletecontents.html
as that was testing specifically detach() which cannot be relevant now
that it is a no-op. Some of the range-* tests are left untouched as they
explicitly call out that detach() is a no-op in comments.

These are the reviews where these deprecation messages were added:
https://codereview.chromium.org/256013002
https://codereview.chromium.org/252783002
https://codereview.chromium.org/901623002

BUG=568218
R=rbyers@chromium.org
==========

[philipj_slow, 2015-12-11 15:29:34]

On 2015/12/11 15:26:50, Rick Byers wrote:
> On 2015/12/11 15:06:53, philipj wrote:
> > On 2015/12/11 15:02:44, Rick Byers wrote:
> > > LGTM, sorry for the delay
> > 
> > I realize this leaves the SVG no-op methods entirely untested, which is why
I
> > insisted on adding this test previously. I'll revive it in another form to
> still
> > have that coverage.
> 
> How do you test that a method is a no-op?  Just that it exists and doesn't
throw
> when called via expected syntax?  That sounds find to me.  I'd also be OK
> depending just on the webexposed tests to verify the APIs existence and a
> comment in the code saying the methods intentionally do nothing.

I've massaged the tests to my liking now, can you take another look? I also
ended up testing that the arguments were required.

[Rick Byers, 2015-12-11 15:55:55]

On 2015/12/11 15:29:34, philipj wrote:
> On 2015/12/11 15:26:50, Rick Byers wrote:
> > On 2015/12/11 15:06:53, philipj wrote:
> > > On 2015/12/11 15:02:44, Rick Byers wrote:
> > > > LGTM, sorry for the delay
> > > 
> > > I realize this leaves the SVG no-op methods entirely untested, which is
why
> I
> > > insisted on adding this test previously. I'll revive it in another form to
> > still
> > > have that coverage.
> > 
> > How do you test that a method is a no-op?  Just that it exists and doesn't
> throw
> > when called via expected syntax?  That sounds find to me.  I'd also be OK
> > depending just on the webexposed tests to verify the APIs existence and a
> > comment in the code saying the methods intentionally do nothing.
> 
> I've massaged the tests to my liking now, can you take another look? I also
> ended up testing that the arguments were required.

Yep, nice to have the extra coverage. Still LGTM

[philipj_slow, 2015-12-11 17:58:29]

The CQ bit was unchecked by philipj@opera.com

[philipj_slow, 2015-12-11 17:58:34]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-12-11 17:58:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1516553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1516553002/40001

[commit-bot: I haz the power, 2015-12-11 18:31:20]

Description was changed from

==========
Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

Take the opportunity to remove the detach() calls from a few tests where
it does nothing anyway. Remove detach-range-during-deletecontents.html
as that was testing specifically detach() which cannot be relevant now
that it is a no-op. Some of the range-* tests are left untouched as they
explicitly call out that detach() is a no-op in comments.

These are the reviews where these deprecation messages were added:
https://codereview.chromium.org/256013002
https://codereview.chromium.org/252783002
https://codereview.chromium.org/901623002

BUG=568218
R=rbyers@chromium.org
==========

to

==========
Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

Take the opportunity to remove the detach() calls from a few tests where
it does nothing anyway. Remove detach-range-during-deletecontents.html
as that was testing specifically detach() which cannot be relevant now
that it is a no-op. Some of the range-* tests are left untouched as they
explicitly call out that detach() is a no-op in comments.

These are the reviews where these deprecation messages were added:
https://codereview.chromium.org/256013002
https://codereview.chromium.org/252783002
https://codereview.chromium.org/901623002

BUG=568218
R=rbyers@chromium.org
==========

[commit-bot: I haz the power, 2015-12-11 18:31:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-11 18:32:39]

Description was changed from

==========
Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

Take the opportunity to remove the detach() calls from a few tests where
it does nothing anyway. Remove detach-range-during-deletecontents.html
as that was testing specifically detach() which cannot be relevant now
that it is a no-op. Some of the range-* tests are left untouched as they
explicitly call out that detach() is a no-op in comments.

These are the reviews where these deprecation messages were added:
https://codereview.chromium.org/256013002
https://codereview.chromium.org/252783002
https://codereview.chromium.org/901623002

BUG=568218
R=rbyers@chromium.org
==========

to

==========
Remove deprecation messages for no-ops that are left in the specs

Since these will not be removed, warning developers about them is
not a good use of attention.

Take the opportunity to remove the detach() calls from a few tests where
it does nothing anyway. Remove detach-range-during-deletecontents.html
as that was testing specifically detach() which cannot be relevant now
that it is a no-op. Some of the range-* tests are left untouched as they
explicitly call out that detach() is a no-op in comments.

These are the reviews where these deprecation messages were added:
https://codereview.chromium.org/256013002
https://codereview.chromium.org/252783002
https://codereview.chromium.org/901623002

BUG=568218
R=rbyers@chromium.org

Committed: https://crrev.com/19739b85c91bc1f7e72565824b14238666d4caf4
Cr-Commit-Position: refs/heads/master@{#364745}
==========

[commit-bot: I haz the power, 2015-12-11 18:32:40]

Patchset 3 (id:??) landed as
https://crrev.com/19739b85c91bc1f7e72565824b14238666d4caf4
Cr-Commit-Position: refs/heads/master@{#364745}