Deprecate SVGSVGElement.forceRedraw, suspendRedraw, unsuspendRedraw[All]

Deprecate SVGSVGElement.forceRedraw, suspendRedraw, unsuspendRedraw[All]

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189639

[Erik Dahlström (inactive), 2015-02-04 13:40:49]

ed@opera.com changed reviewers:
+ pdr@chromium.org, philipj@opera.com

[Erik Dahlström (inactive), 2015-02-04 13:40:49]

Quick smoketest: http://jsfiddle.net/km055x0x/

[philipj_slow, 2015-02-04 15:45:24]

That no tests fail means that this is completely untested. Can you add a test
showing that the deprecation messages are in fact printed? Unlikely as it
sounds, I failed to properly deprecate something once.

https://codereview.chromium.org/901623002/diff/1/Source/core/frame/UseCounter...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/901623002/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.cpp:845: return "'SVGSVGElement.forceRedraw' is
deprecated, please do not use it. It is a no-op, as per SVG2
(https://svgwg.org/svg2-draft/struct.html#__svg__SVGSVGElement__forceRedraw).";
Append () to the function names to match other messages.

https://codereview.chromium.org/901623002/diff/1/Source/core/svg/SVGSVGElemen...
File Source/core/svg/SVGSVGElement.idl (right):

https://codereview.chromium.org/901623002/diff/1/Source/core/svg/SVGSVGElemen...
Source/core/svg/SVGSVGElement.idl:45: [RuntimeEnabled=SVG1DOM,
MeasureAs=SVG1DOM, DeprecateAs=SVGSVGElementSuspendRedraw] unsigned long
suspendRedraw(unsigned long maxWaitMilliseconds);
Have you looked at the generated code to see if both MeasureAs and DeprecateAs
can be used together?

[Erik Dahlström (inactive), 2015-02-05 08:43:00]

https://codereview.chromium.org/901623002/diff/1/Source/core/frame/UseCounter...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/901623002/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.cpp:845: return "'SVGSVGElement.forceRedraw' is
deprecated, please do not use it. It is a no-op, as per SVG2
(https://svgwg.org/svg2-draft/struct.html#__svg__SVGSVGElement__forceRedraw).";
On 2015/02/04 15:45:24, philipj_UTC7 wrote:
> Append () to the function names to match other messages.

Done.

https://codereview.chromium.org/901623002/diff/1/Source/core/svg/SVGSVGElemen...
File Source/core/svg/SVGSVGElement.idl (right):

https://codereview.chromium.org/901623002/diff/1/Source/core/svg/SVGSVGElemen...
Source/core/svg/SVGSVGElement.idl:45: [RuntimeEnabled=SVG1DOM,
MeasureAs=SVG1DOM, DeprecateAs=SVGSVGElementSuspendRedraw] unsigned long
suspendRedraw(unsigned long maxWaitMilliseconds);
On 2015/02/04 15:45:24, philipj_UTC7 wrote:
> Have you looked at the generated code to see if both MeasureAs and DeprecateAs
> can be used together?

I have not, but I have verified that it works through manual testing. But you're
probably right in that it's less likely to break if there's a single counter,
I've changed it to just use DeprecateAs.

[philipj_slow, 2015-02-05 10:03:47]

LG, now just needs a test calling each of the deprecated methods.

[Erik Dahlström (inactive), 2015-02-06 11:19:53]

On 2015/02/05 10:03:47, philipj_UTC7 wrote:
> LG, now just needs a test calling each of the deprecated methods.

Ok, test added. PTAL.

[philipj_slow, 2015-02-06 12:29:05]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-02-06 12:29:05]

lgtm

[commit-bot: I haz the power, 2015-02-06 12:29:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/901623002/60001

[commit-bot: I haz the power, 2015-02-06 13:21:28]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189639