Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1515573002: Safely finalize an AnimationTimeline's still-attached Animations. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Safely finalize an AnimationTimeline's still-attached Animations. R=haraken BUG=568084 Committed: https://crrev.com/6275d5b1652c48f4066f1752a091dea80d26e9ba Cr-Commit-Position: refs/heads/master@{#364300}

Patch Set 1 #

Patch Set 2 : complete the comment #

Patch Set 3 : dispose of AnimationTimelines irrespective of ENABLE(OILPAN) #

Total comments: 4

Patch Set 4 : unconditonally register prefinalizer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M third_party/WebKit/Source/core/animation/Animation.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimeline.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimeline.cpp View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
sof
please take a look, associated bug has some stack traces of what is going wrong ...
5 years ago (2015-12-09 13:50:38 UTC) #2
haraken
https://codereview.chromium.org/1515573002/diff/40001/third_party/WebKit/Source/core/animation/Animation.cpp File third_party/WebKit/Source/core/animation/Animation.cpp (right): https://codereview.chromium.org/1515573002/diff/40001/third_party/WebKit/Source/core/animation/Animation.cpp#newcode114 third_party/WebKit/Source/core/animation/Animation.cpp:114: destroyCompositorPlayer(); Can we remove this now? https://codereview.chromium.org/1515573002/diff/40001/third_party/WebKit/Source/core/animation/AnimationTimeline.cpp File third_party/WebKit/Source/core/animation/AnimationTimeline.cpp ...
5 years ago (2015-12-09 14:02:05 UTC) #5
sof
https://codereview.chromium.org/1515573002/diff/40001/third_party/WebKit/Source/core/animation/Animation.cpp File third_party/WebKit/Source/core/animation/Animation.cpp (right): https://codereview.chromium.org/1515573002/diff/40001/third_party/WebKit/Source/core/animation/Animation.cpp#newcode114 third_party/WebKit/Source/core/animation/Animation.cpp:114: destroyCompositorPlayer(); On 2015/12/09 14:02:04, haraken wrote: > > Can ...
5 years ago (2015-12-09 14:04:33 UTC) #6
haraken
On 2015/12/09 14:04:33, sof wrote: > https://codereview.chromium.org/1515573002/diff/40001/third_party/WebKit/Source/core/animation/Animation.cpp > File third_party/WebKit/Source/core/animation/Animation.cpp (right): > > https://codereview.chromium.org/1515573002/diff/40001/third_party/WebKit/Source/core/animation/Animation.cpp#newcode114 > ...
5 years ago (2015-12-09 14:15:33 UTC) #7
sof
On 2015/12/09 14:15:33, haraken wrote: > On 2015/12/09 14:04:33, sof wrote: > > > https://codereview.chromium.org/1515573002/diff/40001/third_party/WebKit/Source/core/animation/Animation.cpp ...
5 years ago (2015-12-09 14:20:12 UTC) #8
sof
On 2015/12/09 14:20:12, sof wrote: > On 2015/12/09 14:15:33, haraken wrote: > > On 2015/12/09 ...
5 years ago (2015-12-09 14:25:18 UTC) #9
haraken
On 2015/12/09 14:25:18, sof wrote: > On 2015/12/09 14:20:12, sof wrote: > > On 2015/12/09 ...
5 years ago (2015-12-09 15:34:12 UTC) #10
sof
On 2015/12/09 15:34:12, haraken wrote: > On 2015/12/09 14:25:18, sof wrote: > > On 2015/12/09 ...
5 years ago (2015-12-09 15:51:08 UTC) #11
sof
Will let dstockwell@ et al have a say if this is acceptable. Has threaded animation ...
5 years ago (2015-12-09 20:14:25 UTC) #12
haraken
On 2015/12/09 15:51:08, sof wrote: > On 2015/12/09 15:34:12, haraken wrote: > > On 2015/12/09 ...
5 years ago (2015-12-10 01:01:44 UTC) #13
haraken
On 2015/12/10 01:01:44, haraken wrote: > On 2015/12/09 15:51:08, sof wrote: > > On 2015/12/09 ...
5 years ago (2015-12-10 05:28:04 UTC) #14
sof
On 2015/12/10 01:01:44, haraken wrote: > ... > > > > > That said, my ...
5 years ago (2015-12-10 06:31:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515573002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515573002/60001
5 years ago (2015-12-10 06:33:22 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-10 06:38:03 UTC) #20
commit-bot: I haz the power
5 years ago (2015-12-10 06:38:54 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6275d5b1652c48f4066f1752a091dea80d26e9ba
Cr-Commit-Position: refs/heads/master@{#364300}

Powered by Google App Engine
This is Rietveld 408576698