Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: third_party/WebKit/Source/core/animation/Animation.h

Issue 1515573002: Safely finalize an AnimationTimeline's still-attached Animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unconditonally register prefinalizer Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/Animation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/animation/Animation.h
diff --git a/third_party/WebKit/Source/core/animation/Animation.h b/third_party/WebKit/Source/core/animation/Animation.h
index c2a2e8aa6f96e23b69730a0927ca230bdb10ed12..402df1adf5216b8d225aca9c793dfeeb4ab10acf 100644
--- a/third_party/WebKit/Source/core/animation/Animation.h
+++ b/third_party/WebKit/Source/core/animation/Animation.h
@@ -68,8 +68,9 @@ public:
Finished
};
- ~Animation();
static Animation* create(AnimationEffect*, AnimationTimeline*);
+ ~Animation();
+ void dispose();
// Returns whether the animation is finished.
bool update(TimingUpdateReason);
@@ -230,6 +231,7 @@ private:
Member<AnimationEffect> m_content;
Member<AnimationTimeline> m_timeline;
+
// Reflects all pausing, including via pauseForTesting().
bool m_paused;
bool m_held;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/Animation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698