Chromium Code Reviews

Issue 1518883002: make internaldrawBmpText part of GrTextUtils (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
Reviewers:
jvanverth1, joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanuptext10textutils
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

make internaldrawBmpText part of GrTextUtils BUG=skia: Committed: https://skia.googlesource.com/skia/+/296779832fd6175547d991ca67c735a824cadb66

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+167 lines, -139 lines)
M src/gpu/GrAtlasTextContext.h View 1 chunk +0 lines, -10 lines 0 comments
M src/gpu/GrAtlasTextContext.cpp View 7 chunks +21 lines, -115 lines 0 comments
M src/gpu/GrTextContext.h View 1 chunk +2 lines, -1 line 0 comments
M src/gpu/GrTextUtils.h View 2 chunks +38 lines, -13 lines 0 comments
M src/gpu/GrTextUtils.cpp View 1 chunk +106 lines, -0 lines 0 comments

Depends on Patchset:

Issue 1514933002 Patch 1

Dependent Patchsets:

Issue 1521453002 Patch 1

Messages

Total messages: 7 (3 generated)
joshualitt
This CL moves the internal parts of drawBitmapText into GrTextUtils. After this I will do ...
5 years ago (2015-12-10 21:04:16 UTC) #2
bsalomon
lgtm
5 years ago (2015-12-11 13:53:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518883002/1
5 years ago (2015-12-11 13:55:23 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-11 14:09:03 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/296779832fd6175547d991ca67c735a824cadb66

Powered by Google App Engine