Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1514763002: Remove the //mojo/public/c/system:for_component target. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
jamesr, kulakowski
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove the //mojo/public/c/system:for_component target. Should also remove the :for_shared_library target, but that has actual dependents (easy enough to fix, but I'll do it separately). R=jamesr@chromium.org, bueller Committed: https://chromium.googlesource.com/external/mojo/+/0860609cd553f69bb2c4b55aef5efbbef08bf34b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -28 lines) Patch
M mojo/public/c/system/BUILD.gn View 3 chunks +4 lines, -28 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
viettrungluu
5 years ago (2015-12-10 02:02:18 UTC) #1
viettrungluu
-> kulakowski to rubberstamp
5 years ago (2015-12-10 21:15:13 UTC) #4
viettrungluu
Bueller?
5 years ago (2015-12-11 00:42:08 UTC) #7
jamesr
Sorry, slipped through. lgtm
5 years ago (2015-12-11 01:14:27 UTC) #8
viettrungluu
5 years ago (2015-12-11 01:39:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0860609cd553f69bb2c4b55aef5efbbef08bf34b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698