Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: mojo/public/c/system/BUILD.gn

Issue 1514763002: Remove the //mojo/public/c/system:for_component target. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("../../mojo_sdk.gni") 5 import("../../mojo_sdk.gni")
6 6
7 # Depend on this target to use the types etc defined in the system without 7 # This target merely declares the Mojo system API's types, functions, etc. To
8 # linking against a specific implementation of the system. To link against a 8 # use the functions, you must also depend on a specific implementation (e.g.,
9 # particular implementation, use the :for_component or 9 # ../../platform/native:system).
10 # :for_shared_library targets, depending on the type of target you are.
11 mojo_sdk_source_set("system") { 10 mojo_sdk_source_set("system") {
12 sources = [ 11 sources = [
13 "buffer.h", 12 "buffer.h",
14 "core.h", 13 "core.h",
15 "data_pipe.h", 14 "data_pipe.h",
16 "functions.h", 15 "functions.h",
17 "macros.h", 16 "macros.h",
18 "message_pipe.h", 17 "message_pipe.h",
19 "types.h", 18 "types.h",
20 ] 19 ]
21 } 20 }
22 21
23 # In an is_component_build build, everything can link against //mojo/edk/system 22 # TODO(vtl): Remove this.
24 # because it is built as a shared library. However, in a static build,
25 # //mojo/edk/system is linked into an executable (e.g., mojo_shell), and must be
26 # injected into other shared libraries (i.e., Mojo Apps) that need the mojo
27 # system API.
28 #
29 # For component targets, add //mojo/public/c/system:for_component to your deps
30 # section.
31 #
32 # For shared_library targets (e.g., a Mojo App), add
33 # //mojo/public/c/system:for_shared_library to your deps
34
35 # TODO(jamesr): Eliminate the need for these targets. crbug.com/438701
36 group("for_shared_library") { 23 group("for_shared_library") {
37 public_deps = [ 24 public_deps = [
38 ":system", 25 ":system",
39 ] 26 ]
40 deps = [ 27 deps = [
41 "../../platform/native:system", 28 "../../platform/native:system",
42 ] 29 ]
43 } 30 }
44
45 group("for_component") {
46 public_deps = [
47 ":system",
48 ]
49 if (is_component_build) {
50 deps = [
51 "../../../edk/system",
52 ]
53 }
54 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698