Remove the //mojo/public/c/system:for_shared_library target.

Remove the //mojo/public/c/system:for_shared_library target.

I haven't built the targets under //ui/ozone (or don't think I have).
However:
* The dep in //ui/ozone/demo:ozone_demo is certainly wrong:
  - Its own files don't need //mojo/public/c/system (or anything from
    Mojo).
  - If it "needs" //mojo/public/platform/native:system to build, then
    one of its dependencies is busted. In particular, depending on
    .../native:system may allow it to link, but none of the functions
    would actually work (since ozone_demo is a plain executable).
* Similarly, the dep in //ui/ozone/platform/drm:drm_unittests is also
  wrong:
  - This needs //mojo/public/c/system (I think).
  - But depending on .../native:system is similarly broken, since
    eventually this source_set gets built into a (standalone) test
    target ("test()", i.e., an executable).

R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/1835f7ebdc3e8f43410798fc4e2c809b0bb75c48

[viettrungluu, 2015-12-10 16:50:06]

(Dependent on https://codereview.chromium.org/1514763002/.)

https://codereview.chromium.org/1512343002/diff/1/mojo/public/mojo_applicatio...
File mojo/public/mojo_application.gni (left):

https://codereview.chromium.org/1512343002/diff/1/mojo/public/mojo_applicatio...
mojo/public/mojo_application.gni:71: "mojo/public/c/system",
Building the "binary" doesn't need the headers, only the impls (and so things
that need the headers should depend on //mojo/public/c/system directly).

https://codereview.chromium.org/1512343002/diff/1/mojo/public/mojo_applicatio...
File mojo/public/mojo_application.gni (right):

https://codereview.chromium.org/1512343002/diff/1/mojo/public/mojo_applicatio...
mojo/public/mojo_application.gni:309: deps =
This is building a "binary", so should have this dependency (just like
mojo_native_application).

https://codereview.chromium.org/1512343002/diff/1/services/java_handler/BUILD.gn
File services/java_handler/BUILD.gn (left):

https://codereview.chromium.org/1512343002/diff/1/services/java_handler/BUILD...
services/java_handler/BUILD.gn:21: "//mojo/public/c/system:for_shared_library",
Fixed by changing mojo_android_application.

https://codereview.chromium.org/1512343002/diff/1/services/python/content_han...
File services/python/content_handler/BUILD.gn (right):

https://codereview.chromium.org/1512343002/diff/1/services/python/content_han...
services/python/content_handler/BUILD.gn:28: "//mojo/public/c/system",
The .../native:system dependency belongs in the "binary" target (which is
content_handler, which gets it by virtue of being a mojo_native_application).

https://codereview.chromium.org/1512343002/diff/1/services/python/content_han...
services/python/content_handler/BUILD.gn:67: "//mojo/public/c/system",
"

https://codereview.chromium.org/1512343002/diff/1/ui/ozone/demo/BUILD.gn
File ui/ozone/demo/BUILD.gn (left):

https://codereview.chromium.org/1512343002/diff/1/ui/ozone/demo/BUILD.gn#oldc...
ui/ozone/demo/BUILD.gn:28: "//mojo/public/c/system:for_shared_library",
See commit message.

https://codereview.chromium.org/1512343002/diff/1/ui/ozone/platform/drm/BUILD.gn
File ui/ozone/platform/drm/BUILD.gn (left):

https://codereview.chromium.org/1512343002/diff/1/ui/ozone/platform/drm/BUILD...
ui/ozone/platform/drm/BUILD.gn:180: "//mojo/public/c/system:for_shared_library",
"

[viettrungluu, 2015-12-11 01:38:16]

Ping on this one too (but you may have to think about it)....

[jamesr, 2015-12-11 01:42:29]

ozone / drm test targets are probably buggered.  try them in an FNL build -
that's what uses ozone / fnl.  To do that follow the instructions
https://fuchsia.googlesource.com/fnl-start/ and then run mojob.py gn --fnl and
pass whatever toolchain root parameter it requires into the toolchain inside fnl

[jamesr, 2015-12-11 01:44:03]

https://codereview.chromium.org/1512343002/diff/1/examples/tiny/BUILD.gn
File examples/tiny/BUILD.gn (right):

https://codereview.chromium.org/1512343002/diff/1/examples/tiny/BUILD.gn#newc...
examples/tiny/BUILD.gn:13: "//mojo/public/c/system",
maybe this should be public_deps in the mojo_native_application? hard to write
any sort of native application w/out depending on the system entry points

[kulakowski1, 2015-12-11 01:44:09]

On 2015/12/11 01:42:29, jamesr wrote:
> ozone / drm test targets are probably buggered.  try them in an FNL build -
> that's what uses ozone / fnl.  To do that follow the instructions
> https://fuchsia.googlesource.com/fnl-start/ and then run mojob.py gn --fnl and
> pass whatever toolchain root parameter it requires into the toolchain inside
fnl

I'm currently recreating a clean fnl checkout and don't yet have mojo cloned
into my world. If you'd like help looking at this I can help tomorrow.

[jamesr, 2015-12-11 01:46:02]

I had no issue making a clean fnl checkout somewhere unrelated to my mojo
checkout on disk and just pointing my existing mojo checkout at the fnl
toolchain when running gn.

[viettrungluu, 2015-12-11 01:54:13]

On 2015/12/11 01:44:03, jamesr wrote:
> https://codereview.chromium.org/1512343002/diff/1/examples/tiny/BUILD.gn
> File examples/tiny/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1512343002/diff/1/examples/tiny/BUILD.gn#newc...
> examples/tiny/BUILD.gn:13: "//mojo/public/c/system",
> maybe this should be public_deps in the mojo_native_application? hard to write
> any sort of native application w/out depending on the system entry points

The question is whether you're using them directly or not.

To get the system entrypoints themselves, you just need the .../native:system
dependency. You just may end up using them indirectly via some library (which
may or may not bury its dependency on .../c/system, i.e., have it as a public
dep or not).

[jamesr, 2015-12-11 08:48:00]

Good point.  Did you get a chance to test the ozone/drm test targets? rest lgtm
but it'd be good to know if those changes link too before landing

[viettrungluu, 2015-12-11 18:08:48]

On 2015/12/11 08:48:00, jamesr wrote:
> Good point.  Did you get a chance to test the ozone/drm test targets? rest
lgtm
> but it'd be good to know if those changes link too before landing

OK, I'm going to break stuff. And then someone (I/you/George) will fix it.

[viettrungluu, 2015-12-11 18:09:03]

Description was changed from

==========
Remove the //mojo/public/c/system:for_shared_library target.

I haven't built the targets under //ui/ozone (or don't think I have).
However:
* The dep in //ui/ozone/demo:ozone_demo is certainly wrong:
  - Its own files don't need //mojo/public/c/system (or anything from
    Mojo).
  - If it "needs" //mojo/public/platform/native:system to build, then
    one of its dependencies is busted. In particular, depending on
    .../native:system may allow it to link, but none of the functions
    would actually work (since ozone_demo is a plain executable).
* Similarly, the dep in //ui/ozone/platform/drm:drm_unittests is also
  wrong:
  - This needs //mojo/public/c/system (I think).
  - But depending on .../native:system is similarly broken, since
    eventually this source_set gets built into a (standalone) test
    target ("test()", i.e., an executable).

R=jamesr@chromium.org
==========

to

==========
Remove the //mojo/public/c/system:for_shared_library target.

I haven't built the targets under //ui/ozone (or don't think I have).
However:
* The dep in //ui/ozone/demo:ozone_demo is certainly wrong:
  - Its own files don't need //mojo/public/c/system (or anything from
    Mojo).
  - If it "needs" //mojo/public/platform/native:system to build, then
    one of its dependencies is busted. In particular, depending on
    .../native:system may allow it to link, but none of the functions
    would actually work (since ozone_demo is a plain executable).
* Similarly, the dep in //ui/ozone/platform/drm:drm_unittests is also
  wrong:
  - This needs //mojo/public/c/system (I think).
  - But depending on .../native:system is similarly broken, since
    eventually this source_set gets built into a (standalone) test
    target ("test()", i.e., an executable).

R=jamesr@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/1835f7ebdc3e8f43410798fc4e2...
==========

[viettrungluu, 2015-12-11 18:09:05]

Committed patchset #1 (id:1) manually as
1835f7ebdc3e8f43410798fc4e2c809b0bb75c48 (presubmit successful).