Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 1514553002: Revert of Boost GrGLConicEffect's variables to all high precision (Closed)

Created:
5 years ago by robertphillips
Modified:
5 years ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Boost GrGLConicEffect's variables to all high precision (patchset #1 id:1 of https://codereview.chromium.org/1513483002/ ) Reason for revert: Broke build Original issue's description: > Boost GrGLConicEffect's variables to all high precision > > BUG=555779 > > Committed: https://skia.googlesource.com/skia/+/624c59a1c7af38eb83e803f345a6f3e225475a08 TBR=egdaniel@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=555779 Committed: https://skia.googlesource.com/skia/+/07073642eb471d84aa56b5f695f129d793556eaf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -77 lines) Patch
M gyp/SampleApp.gyp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 5 chunks +39 lines, -73 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Boost GrGLConicEffect's variables to all high precision
5 years ago (2015-12-09 15:09:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514553002/1
5 years ago (2015-12-09 15:09:11 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-09 15:09:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/07073642eb471d84aa56b5f695f129d793556eaf

Powered by Google App Engine
This is Rietveld 408576698