Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Issue 1514193002: use bot_utils.run to run dartdoc so that the bot will fail if there are errors (Closed)

Created:
5 years ago by keertip
Modified:
5 years ago
Reviewers:
ricow1, Bill Hesse
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

use bot_utils.run to run dartdoc so that the bot will fail if there are errors when dartdoc is run. This will catch failures to generate docs. BUG=https://github.com/dart-lang/sdk/issues/25015 R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/c88841c041ff9c19a1511e47964b5b306f78df46

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M tools/bots/dart_sdk.py View 1 chunk +3 lines, -5 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
keertip
5 years ago (2015-12-10 22:22:29 UTC) #3
Bill Hesse
lgtm
5 years ago (2015-12-10 22:58:10 UTC) #5
Bill Hesse
lgtm lgtm
5 years ago (2015-12-10 22:58:23 UTC) #6
ricow1
https://codereview.chromium.org/1514193002/diff/1/tools/bots/dart_sdk.py File tools/bots/dart_sdk.py (right): https://codereview.chromium.org/1514193002/diff/1/tools/bots/dart_sdk.py#newcode42 tools/bots/dart_sdk.py:42: bot_utils.run([dart_exe, '--package-root=' + packages_dir, dartdoc_dart, Just Run to be ...
5 years ago (2015-12-11 06:29:31 UTC) #8
keertip
Committed patchset #1 (id:1) manually as c88841c041ff9c19a1511e47964b5b306f78df46 (presubmit successful).
5 years ago (2015-12-11 16:03:59 UTC) #10
keertip
5 years ago (2015-12-11 16:28:30 UTC) #11
Message was sent while issue was closed.
On 2015/12/11 06:29:31, ricow1 wrote:
> https://codereview.chromium.org/1514193002/diff/1/tools/bots/dart_sdk.py
> File tools/bots/dart_sdk.py (right):
> 
>
https://codereview.chromium.org/1514193002/diff/1/tools/bots/dart_sdk.py#newc...
> tools/bots/dart_sdk.py:42: bot_utils.run([dart_exe, '--package-root=' +
> packages_dir, dartdoc_dart,
> Just Run to be consistent with the rest of this file

Sorry Rico, saw your comment only after I committed the cl. Will change next
time.

Powered by Google App Engine
This is Rietveld 408576698