Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: tools/bots/dart_sdk.py

Issue 1514193002: use bot_utils.run to run dartdoc so that the bot will fail if there are errors (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/dart_sdk.py
diff --git a/tools/bots/dart_sdk.py b/tools/bots/dart_sdk.py
index decf8766ab67e9f50845fdaa6351b56231cea0a1..795288538a1ec813772b05a4917ede366efc7c14 100644
--- a/tools/bots/dart_sdk.py
+++ b/tools/bots/dart_sdk.py
@@ -39,11 +39,9 @@ def BuildDartdocAPIDocs(dirname):
'tools', 'bots', 'dartdoc_footer.html')
url = 'https://api.dartlang.org/stable'
with bot.BuildStep('Build API docs by dartdoc'):
- subprocess.call([dart_exe, '--package-root=' + packages_dir, dartdoc_dart,
- '--sdk-docs','--output', dirname, '--dart-sdk', dart_sdk,
- '--footer' , footer_file,
- '--rel-canonical-prefix=' + url],
- stdout=open(os.devnull, 'wb'))
+ bot_utils.run([dart_exe, '--package-root=' + packages_dir, dartdoc_dart,
ricow1 2015/12/11 06:29:30 Just Run to be consistent with the rest of this fi
+ '--sdk-docs','--output', dirname, '--dart-sdk', dart_sdk,
+ '--footer' , footer_file, '--rel-canonical-prefix=' + url])
def CreateUploadVersionFile():
file_path = os.path.join(bot_utils.DART_DIR,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698