use bot_utils.run to run dartdoc so that the bot will fail if there are errors

tools/bots/dart_sdk.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import os.path
 import shutil
 import sys
 import subprocess
@@ skipping 21 matching lines @@
   dartdoc_dart = os.path.join(bot_utils.DART_DIR,
                               'third_party', 'pkg' , 'dartdoc' , 'bin' , 
                               'dartdoc.dart')
   packages_dir = os.path.join(bot_utils.DART_DIR,
                               utils.GetBuildRoot(BUILD_OS, 'release', 'ia32'),
                               'packages')
   footer_file = os.path.join(bot_utils.DART_DIR,
                               'tools', 'bots', 'dartdoc_footer.html')
   url = 'https://api.dartlang.org/stable'
   with bot.BuildStep('Build API docs by dartdoc'):
-    subprocess.call([dart_exe, '--package-root=' + packages_dir, dartdoc_dart, 
-                    '--sdk-docs','--output', dirname, '--dart-sdk', dart_sdk, 
-                    '--footer' , footer_file,
-                    '--rel-canonical-prefix=' + url], 
-                     stdout=open(os.devnull, 'wb'))
+    bot_utils.run([dart_exe, '--package-root=' + packages_dir, dartdoc_dart, 

[ricow1, 2015/12/11 06:29:30]

Just Run to be consistent with the rest of this file

+                  '--sdk-docs','--output', dirname, '--dart-sdk', dart_sdk, 
+                  '--footer' , footer_file, '--rel-canonical-prefix=' + url])
 
 def CreateUploadVersionFile():
   file_path = os.path.join(bot_utils.DART_DIR,
                            utils.GetBuildRoot(BUILD_OS, 'release', 'ia32'),
                            'VERSION')
   with open(file_path, 'w') as fd:
     fd.write(utils.GetVersionFileContent())
   DartArchiveUploadVersionFile(file_path)
 
 def DartArchiveUploadVersionFile(version_file):
@@ skipping 148 matching lines @@
 
 if __name__ == '__main__':
   # We always clobber the bot, to make sure releases are build from scratch
   force = CHANNEL != bot_utils.Channel.BLEEDING_EDGE
   bot.Clobber(force=force)
 
   CreateUploadSDK()
   if BUILD_OS == 'linux':
     CreateUploadVersionFile()
     CreateUploadAPIDocs()