Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1513483002:
Boost GrGLConicEffect's variables to all high precision (Closed)
|
Created:
5 years ago by robertphillips Modified:
5 years ago Reviewers:
egdaniel CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionBoost GrGLConicEffect's variables to all high precision
BUG=555779
Committed: https://skia.googlesource.com/skia/+/624c59a1c7af38eb83e803f345a6f3e225475a08
Committed: https://skia.googlesource.com/skia/+/96afa5295d2bb0ceae3f584a96a786b22b2c5b89
Patch Set 1 #Patch Set 2 : Doh #
Messages
Total messages: 27 (13 generated)
Description was changed from ========== Boost GrGLConixEffect's variables to all high precision BUG=555779 ========== to ========== Boost GrGLConicEffect's variables to all high precision BUG=555779 ==========
robertphillips@google.com changed reviewers: + egdaniel@google.com
This lgtm, but maybe try just setting the conic coeff varying to highp and see if that alone works. Otherwise keep as is.
Patchset #2 (id:20001) has been deleted
Just making the "ConicCoeffs" varying high precision didn't fix the bug :(
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513483002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513483002/1
Message was sent while issue was closed.
Description was changed from ========== Boost GrGLConicEffect's variables to all high precision BUG=555779 ========== to ========== Boost GrGLConicEffect's variables to all high precision BUG=555779 Committed: https://skia.googlesource.com/skia/+/624c59a1c7af38eb83e803f345a6f3e225475a08 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/624c59a1c7af38eb83e803f345a6f3e225475a08
Message was sent while issue was closed.
On 2015/12/09 14:28:09, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://skia.googlesource.com/skia/+/624c59a1c7af38eb83e803f345a6f3e225475a08 Sorry to chime in with a question, but in light of https://code.google.com/p/chromium/issues/detail?id=567894 - is this going to have problems on Android One devices?
Message was sent while issue was closed.
It sounds like we will have to revert to breaking the conics into quads or lines for Android One devices. We just got some in-house so we should know more soon.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1514553002/ by robertphillips@google.com. The reason for reverting is: Broke build.
Message was sent while issue was closed.
Description was changed from ========== Boost GrGLConicEffect's variables to all high precision BUG=555779 Committed: https://skia.googlesource.com/skia/+/624c59a1c7af38eb83e803f345a6f3e225475a08 ========== to ========== Boost GrGLConicEffect's variables to all high precision BUG=555779 Committed: https://skia.googlesource.com/skia/+/624c59a1c7af38eb83e803f345a6f3e225475a08 ==========
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513483002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com Link to the patchset: https://codereview.chromium.org/1513483002/#ps40001 (title: "Doh")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513483002/40001
Message was sent while issue was closed.
Description was changed from ========== Boost GrGLConicEffect's variables to all high precision BUG=555779 Committed: https://skia.googlesource.com/skia/+/624c59a1c7af38eb83e803f345a6f3e225475a08 ========== to ========== Boost GrGLConicEffect's variables to all high precision BUG=555779 Committed: https://skia.googlesource.com/skia/+/624c59a1c7af38eb83e803f345a6f3e225475a08 Committed: https://skia.googlesource.com/skia/+/96afa5295d2bb0ceae3f584a96a786b22b2c5b89 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://skia.googlesource.com/skia/+/96afa5295d2bb0ceae3f584a96a786b22b2c5b89 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
