Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 1513153002: Border::CreateBorderPainter now takes a unique_ptr, not a raw pointer. (Closed)

Created:
5 years ago by Matt Giuca
Modified:
4 years, 8 months ago
Reviewers:
Peter Kasting, sadrul
CC:
chromium-reviews, tfarina, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@border-unittest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Border::CreateBorderPainter now takes a unique_ptr, not a raw pointer. Now the ownership is enforced by the type, rather than having to be explained in a comment. Committed: https://crrev.com/5e45bd7cbb42f0c5251b140e374ce9589a00a110 Cr-Commit-Position: refs/heads/master@{#387200}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Patch Set 5 : Avoid dependency on unsubmitted CL. #

Patch Set 6 : Switch to unique_ptr. #

Patch Set 7 : Rebase (rest of border switched to unique_ptr). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M chrome/browser/ui/views/dropdown_bar_view.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/border.h View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/border.cc View 1 2 3 4 5 6 3 chunks +9 lines, -8 lines 0 comments Download
M ui/views/controls/menu/menu_scroll_view_container.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Matt Giuca
This is definitely going to conflict with a CL that I suspect is coming in ...
4 years, 8 months ago (2016-04-11 01:57:02 UTC) #5
Matt Giuca
sadrul: Please review changes in ui/views. pkasting: TBR for dropdown_bar_view mechanical change.
4 years, 8 months ago (2016-04-13 06:53:38 UTC) #7
sadrul
cool. lgtm
4 years, 8 months ago (2016-04-13 15:21:14 UTC) #8
Peter Kasting
LGTM
4 years, 8 months ago (2016-04-13 19:59:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513153002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513153002/140001
4 years, 8 months ago (2016-04-14 00:43:54 UTC) #12
commit-bot: I haz the power
Committed patchset #7 (id:140001)
4 years, 8 months ago (2016-04-14 01:36:22 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 01:38:36 UTC) #16
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/5e45bd7cbb42f0c5251b140e374ce9589a00a110
Cr-Commit-Position: refs/heads/master@{#387200}

Powered by Google App Engine
This is Rietveld 408576698