Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: ui/views/border.h

Issue 1513153002: Border::CreateBorderPainter now takes a unique_ptr, not a raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@border-unittest
Patch Set: Rebase (rest of border switched to unique_ptr). Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/dropdown_bar_view.cc ('k') | ui/views/border.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_BORDER_H_ 5 #ifndef UI_VIEWS_BORDER_H_
6 #define UI_VIEWS_BORDER_H_ 6 #define UI_VIEWS_BORDER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 int right); 66 int right);
67 67
68 // Creates a border of the specified color, and specified thickness on each 68 // Creates a border of the specified color, and specified thickness on each
69 // side. 69 // side.
70 static std::unique_ptr<Border> CreateSolidSidedBorder(int top, 70 static std::unique_ptr<Border> CreateSolidSidedBorder(int top,
71 int left, 71 int left,
72 int bottom, 72 int bottom,
73 int right, 73 int right,
74 SkColor color); 74 SkColor color);
75 75
76 // Creates a Border from the specified Painter. The border owns the painter, 76 // Creates a Border from the specified Painter.
77 // thus the painter is deleted when the Border is deleted.
78 // |insets| define size of an area allocated for a Border. 77 // |insets| define size of an area allocated for a Border.
79 static std::unique_ptr<Border> CreateBorderPainter(Painter* painter, 78 static std::unique_ptr<Border> CreateBorderPainter(
80 const gfx::Insets& insets); 79 std::unique_ptr<Painter> painter,
80 const gfx::Insets& insets);
81 81
82 // Renders the border for the specified view. 82 // Renders the border for the specified view.
83 virtual void Paint(const View& view, gfx::Canvas* canvas) = 0; 83 virtual void Paint(const View& view, gfx::Canvas* canvas) = 0;
84 84
85 // Returns the border insets. 85 // Returns the border insets.
86 virtual gfx::Insets GetInsets() const = 0; 86 virtual gfx::Insets GetInsets() const = 0;
87 87
88 // Returns the minimum size this border requires. Note that this may not be 88 // Returns the minimum size this border requires. Note that this may not be
89 // the same as the insets. For example, a Border may paint images to draw 89 // the same as the insets. For example, a Border may paint images to draw
90 // some graphical border around a view, and this would return the minimum size 90 // some graphical border around a view, and this would return the minimum size
91 // such that these images would not be clipped or overlapping -- but the 91 // such that these images would not be clipped or overlapping -- but the
92 // insets may be larger or smaller, depending on how the view wanted its 92 // insets may be larger or smaller, depending on how the view wanted its
93 // content laid out relative to these images. 93 // content laid out relative to these images.
94 virtual gfx::Size GetMinimumSize() const = 0; 94 virtual gfx::Size GetMinimumSize() const = 0;
95 95
96 private: 96 private:
97 DISALLOW_COPY_AND_ASSIGN(Border); 97 DISALLOW_COPY_AND_ASSIGN(Border);
98 }; 98 };
99 99
100 } // namespace views 100 } // namespace views
101 101
102 #endif // UI_VIEWS_BORDER_H_ 102 #endif // UI_VIEWS_BORDER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/dropdown_bar_view.cc ('k') | ui/views/border.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698