Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: ui/views/border.h

Issue 1513153002: Border::CreateBorderPainter now takes a unique_ptr, not a raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@border-unittest
Patch Set: Rebase (rest of border switched to unique_ptr). Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/dropdown_bar_view.cc ('k') | ui/views/border.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/border.h
diff --git a/ui/views/border.h b/ui/views/border.h
index 1afc55c8bc5ad7a5882ac7c10f0688ce9773093a..d30cc7ca0b00e2882b2b5288d9b058a98fa3858d 100644
--- a/ui/views/border.h
+++ b/ui/views/border.h
@@ -73,11 +73,11 @@ class VIEWS_EXPORT Border {
int right,
SkColor color);
- // Creates a Border from the specified Painter. The border owns the painter,
- // thus the painter is deleted when the Border is deleted.
+ // Creates a Border from the specified Painter.
// |insets| define size of an area allocated for a Border.
- static std::unique_ptr<Border> CreateBorderPainter(Painter* painter,
- const gfx::Insets& insets);
+ static std::unique_ptr<Border> CreateBorderPainter(
+ std::unique_ptr<Painter> painter,
+ const gfx::Insets& insets);
// Renders the border for the specified view.
virtual void Paint(const View& view, gfx::Canvas* canvas) = 0;
« no previous file with comments | « chrome/browser/ui/views/dropdown_bar_view.cc ('k') | ui/views/border.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698