win: Get Kasko crash keys from Crashpad instead of Breakpad

components/crash/content/app/crashpad_win.cc

Index: components/crash/content/app/crashpad_win.cc
diff --git a/components/crash/content/app/crashpad_win.cc b/components/crash/content/app/crashpad_win.cc
index 07c235ea2147c351d2ce7a885c9f377468e5e8d0..1c46921015e4f90434abd07329a875100a093370 100644
--- a/components/crash/content/app/crashpad_win.cc
+++ b/components/crash/content/app/crashpad_win.cc
@@ -4,6 +4,7 @@
 
 #include "components/crash/content/app/crashpad.h"
 
+#include "base/debug/crash_logging.h"
 #include "base/environment.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
@@ -113,6 +114,21 @@ int __declspec(dllexport) CrashForException(
   return EXCEPTION_CONTINUE_SEARCH;
 }
 
+// NOTE: This function is used by SyzyASAN to annotate crash reports. If you
+// change the name or signature of this function you will break SyzyASAN
+// instrumented releases of Chrome. Please contact syzygy-team@chromium.org
+// before doing so! See also http://crbug.com/567781.
+void __declspec(dllexport) __cdecl SetCrashKeyValueImpl(

[chrisha, 2015/12/08 21:07:57]

Won't this be doubly defined now because of breakpad_win.cc as well? Or is that
file removed from the build when Crashpad is enabled?

[scottmg, 2015/12/08 22:16:44]

Right, breakpad_win.cc isn't compiled into Chrome any more.

+    const wchar_t* key, const wchar_t* value) {
+  base::debug::SetCrashKeyValue(base::UTF16ToUTF8(key),
+                                base::UTF16ToUTF8(value));
+}
+
+void __declspec(dllexport) __cdecl ClearCrashKeyValueImpl(
+    const wchar_t* key) {
+  base::debug::ClearCrashKey(base::UTF16ToUTF8(key));
+}
+
 // TODO(scottmg): http://crbug.com/546288 These exported functions are for
 // compatibility with how Breakpad worked, but it seems like there's no need to
 // do the CreateRemoteThread() dance with a minor extension of the Crashpad API