win: Get Kasko crash keys from Crashpad instead of Breakpad

components/crash/content/app/crashpad_win.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/crash/content/app/crashpad.h"
 
+#include "base/debug/crash_logging.h"
 #include "base/environment.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/path_service.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "components/crash/content/app/crash_reporter_client.h"
@@ skipping 89 matching lines @@
 // for it to do anything.
 // NOTE: This function is used by SyzyASAN to invoke a crash. If you change the
 // the name or signature of this function you will break SyzyASAN instrumented
 // releases of Chrome. Please contact syzygy-team@chromium.org before doing so!
 int __declspec(dllexport) CrashForException(
     EXCEPTION_POINTERS* info) {
   g_crashpad_client.Get().DumpAndCrash(info);
   return EXCEPTION_CONTINUE_SEARCH;
 }
 
+// NOTE: This function is used by SyzyASAN to annotate crash reports. If you
+// change the name or signature of this function you will break SyzyASAN
+// instrumented releases of Chrome. Please contact syzygy-team@chromium.org
+// before doing so! See also http://crbug.com/567781.
+void __declspec(dllexport) __cdecl SetCrashKeyValueImpl(

[chrisha, 2015/12/08 21:07:57]

Won't this be doubly defined now because of breakpad_win.cc as well? Or is that
file removed from the build when Crashpad is enabled?

[scottmg, 2015/12/08 22:16:44]

Right, breakpad_win.cc isn't compiled into Chrome any more.

+    const wchar_t* key, const wchar_t* value) {
+  base::debug::SetCrashKeyValue(base::UTF16ToUTF8(key),
+                                base::UTF16ToUTF8(value));
+}
+
+void __declspec(dllexport) __cdecl ClearCrashKeyValueImpl(
+    const wchar_t* key) {
+  base::debug::ClearCrashKey(base::UTF16ToUTF8(key));
+}
+
 // TODO(scottmg): http://crbug.com/546288 These exported functions are for
 // compatibility with how Breakpad worked, but it seems like there's no need to
 // do the CreateRemoteThread() dance with a minor extension of the Crashpad API
 // (to just pass the pid we want a dump for). We should add that and then modify
 // hang_crash_dump_win.cc to work in a more direct manner.
 
 // Used for dumping a process state when there is no crash.
 extern "C" void __declspec(dllexport) __cdecl DumpProcessWithoutCrash() {
   CRASHPAD_SIMULATE_CRASH();
 }
@@ skipping 121 matching lines @@
       reinterpret_cast<ExceptionHandlerRecord*>(start);
 
   CHECK(RtlDeleteFunctionTable(&record->runtime_function));
 }
 #endif  // ARCH_CPU_X86_64
 
 }  // extern "C"
 
 }  // namespace internal
 }  // namespace crash_reporter