win: Get Kasko crash keys from Crashpad instead of Breakpad

components/crash/content/app/crashpad.h

Index: components/crash/content/app/crashpad.h
diff --git a/components/crash/content/app/crashpad.h b/components/crash/content/app/crashpad.h
index 6121efb14657dca733e6657557e240db03690073..b927c39d634fa19c5055cd565ed3b163a8ff8f91 100644
--- a/components/crash/content/app/crashpad.h
+++ b/components/crash/content/app/crashpad.h
@@ -8,6 +8,7 @@
 #include <time.h>
 
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "base/files/file_path.h"
@@ -70,6 +71,9 @@ struct UploadedReport {
 // disabled.
 void GetUploadedReports(std::vector<UploadedReport>* uploaded_reports);
 
+// Returns a copy of the current crash keys.
+std::vector<std::pair<std::string, std::string>> GetCrashKeys();

[chrisha, 2015/12/08 21:07:57]

If we're poking a hole here, we could always just write directly into the final
format, and avoid the multiple conversions and allocations? 

Define a compatible type here (lifted from crash_keys.h), 
ad make this simply write directly into a provided std::vector?

[scottmg, 2015/12/08 22:16:44]

I didn't really like the ~20 lines of static_assert that required, and I don't
want to include Kasko headers into Crashpad. So I thought it was better to do
the truncation to wchar[64] in the Kasko code. But you're right that it'd be
less allocations.

Mark, any preference either for the components/crash/... code?

[Mark Mentovai, 2015/12/10 23:35:55]

Well if you’re saying that this should be doing truncation, I’m afraid…

https://msdn.microsoft.com/en-us/library/td1esda9
(the last row in the Error Conditions table under Return Value)

[Mark Mentovai, 2015/12/10 23:35:55]

Conceptually it’s more of a map<string, string>, although if you had a reason to
not do that, this is fine too.

+
 namespace internal {
 
 // The platform-specific portion of InitializeCrashpad().