Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1511223002: MIPS: [turbofan] Fix Div operations by zero on r6. (Closed)

Created:
5 years ago by dusan.milosavljevic
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Fix Div operations by zero on r6. TEST=cctest/test-run-machops/RunInt32DivP BUG= Committed: https://crrev.com/3950ca1b1ee6269bed649970a7c8091b569cc83b Cr-Commit-Position: refs/heads/master@{#32716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dusan.milosavljevic
PTAL.
5 years ago (2015-12-09 13:43:17 UTC) #2
paul.l...
LGTM.
5 years ago (2015-12-09 13:53:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511223002/1
5 years ago (2015-12-09 14:05:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 14:28:13 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-09 14:28:56 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3950ca1b1ee6269bed649970a7c8091b569cc83b
Cr-Commit-Position: refs/heads/master@{#32716}

Powered by Google App Engine
This is Rietveld 408576698