chrome/browser/extensions/permission_messages_unittest.cc - Issue 1511103003: Use rvalue reference instead of ExtensionBuilder::pass()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/permission_messages_unittest.cc

Issue 1511103003: Use rvalue reference instead of ExtensionBuilder::pass() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit change(dana review) Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/file_system/file_system_api_unittest.cc ('k') | chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/permission_messages_unittest.cc

diff --git a/chrome/browser/extensions/permission_messages_unittest.cc b/chrome/browser/extensions/permission_messages_unittest.cc

index c2a9530826b7be16f2d11ac57bd405b2da255ebb..3d0a0a64fa2e9a0cb3556386c40d4865aa482aa2 100644

--- a/chrome/browser/extensions/permission_messages_unittest.cc

+++ b/chrome/browser/extensions/permission_messages_unittest.cc

@@ -52,7 +52,7 @@ class PermissionMessagesUnittest : public testing::Test {

protected:

void CreateAndInstallAppWithPermissions(ListBuilder required_permissions,

ListBuilder optional_permissions) {

- app_ = test_util::BuildApp(ExtensionBuilder().Pass())

+ app_ = test_util::BuildApp(ExtensionBuilder())

.MergeManifest(

DictionaryBuilder()

.Set("permissions", std::move(required_permissions))

@@ -67,7 +67,7 @@ class PermissionMessagesUnittest : public testing::Test {

void CreateAndInstallExtensionWithPermissions(

ListBuilder required_permissions,

ListBuilder optional_permissions) {

- app_ = test_util::BuildExtension(ExtensionBuilder().Pass())

+ app_ = test_util::BuildExtension(ExtensionBuilder())

.MergeManifest(

DictionaryBuilder()

.Set("permissions", std::move(required_permissions))