chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc - Issue 1511103003: Use rvalue reference instead of ExtensionBuilder::pass()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc

Issue 1511103003: Use rvalue reference instead of ExtensionBuilder::pass() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit change(dana review) Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/permission_messages_unittest.cc ('k') | chrome/common/extensions/api/common_extension_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc

diff --git a/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc b/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc

index 768db1ffb204cc9c63356ad9582cb83f6a7e933a..c33173f59dd6fda9f8257a7692fe273b2bc2909d 100644

--- a/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc

+++ b/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc

@@ -115,7 +115,7 @@ TEST_F(MediaRouterUITest, GetExtensionNameExtensionPresent) {

scoped_ptr<extensions::ExtensionRegistry> registry =

make_scoped_ptr(new extensions::ExtensionRegistry(nullptr));

scoped_refptr<extensions::Extension> app =

- extensions::test_util::BuildApp(extensions::ExtensionBuilder().Pass())

+ extensions::test_util::BuildApp(extensions::ExtensionBuilder())

.MergeManifest(

extensions::DictionaryBuilder().Set("name", "test app name"))

.SetID(id)