Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: chrome/browser/extensions/api/file_system/file_system_api_unittest.cc

Issue 1511103003: Use rvalue reference instead of ExtensionBuilder::pass() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit change(dana review) Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/permission_messages_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/file_system/file_system_api_unittest.cc
diff --git a/chrome/browser/extensions/api/file_system/file_system_api_unittest.cc b/chrome/browser/extensions/api/file_system/file_system_api_unittest.cc
index 62b2775b36d152bc668f537c4492d3e67d7689c8..69c0855f2b5699890c87c5aaef1724632b0e78c8 100644
--- a/chrome/browser/extensions/api/file_system/file_system_api_unittest.cc
+++ b/chrome/browser/extensions/api/file_system/file_system_api_unittest.cc
@@ -316,7 +316,8 @@ TEST_F(FileSystemApiConsentProviderTest, ForNonKioskApps) {
// Component apps are not granted unless they are whitelisted.
{
scoped_refptr<Extension> component_extension(
- test_util::BuildApp(ExtensionBuilder().SetLocation(Manifest::COMPONENT))
+ test_util::BuildApp(
+ std::move(ExtensionBuilder().SetLocation(Manifest::COMPONENT)))
.Build());
TestingConsentProviderDelegate delegate;
ConsentProvider provider(&delegate);
@@ -327,7 +328,8 @@ TEST_F(FileSystemApiConsentProviderTest, ForNonKioskApps) {
// user.
{
scoped_refptr<Extension> whitelisted_component_extension(
- test_util::BuildApp(ExtensionBuilder().SetLocation(Manifest::COMPONENT))
+ test_util::BuildApp(
+ std::move(ExtensionBuilder().SetLocation(Manifest::COMPONENT)))
.Build());
TestingConsentProviderDelegate delegate;
delegate.SetComponentWhitelist(whitelisted_component_extension->id());
@@ -361,7 +363,7 @@ TEST_F(FileSystemApiConsentProviderTest, ForKioskApps) {
// instantly without asking for user consent, but with a notification.
{
scoped_refptr<Extension> auto_launch_kiosk_app(
- test_util::BuildApp(ExtensionBuilder().Pass())
+ test_util::BuildApp(ExtensionBuilder())
.MergeManifest(DictionaryBuilder()
.SetBoolean("kiosk_enabled", true)
.SetBoolean("kiosk_only", true))
@@ -390,7 +392,7 @@ TEST_F(FileSystemApiConsentProviderTest, ForKioskApps) {
// Non-component apps in manual-launch kiosk mode will be granted access after
// receiving approval from the user.
scoped_refptr<Extension> manual_launch_kiosk_app(
- test_util::BuildApp(ExtensionBuilder().Pass())
+ test_util::BuildApp(ExtensionBuilder())
.MergeManifest(DictionaryBuilder()
.SetBoolean("kiosk_enabled", true)
.SetBoolean("kiosk_only", true))
« no previous file with comments | « no previous file | chrome/browser/extensions/permission_messages_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698