Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1510493002: MIPS: [turbofan] Combine ChangeFloat64ToInt32 with Float64Round ops. (Closed)

Created:
5 years ago by dusan.milosavljevic
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Combine ChangeFloat64ToInt32 with Float64Round ops. TEST=unittests/InstructionSlectorTest.CombineChangeFloat64ToInt32WithRoundFloat64 BUG= Committed: https://crrev.com/0d4f8a913dc01475501f238e03099d4301b86c3c Cr-Commit-Position: refs/heads/master@{#32668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -0 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 2 chunks +36 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dusan.milosavljevic
PTAL.
5 years ago (2015-12-07 16:16:29 UTC) #2
titzer
On 2015/12/07 16:16:29, dusan.milosavljevic wrote: > PTAL. lgtm
5 years ago (2015-12-07 16:40:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510493002/1
5 years ago (2015-12-07 23:12:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 23:35:54 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-07 23:36:40 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0d4f8a913dc01475501f238e03099d4301b86c3c
Cr-Commit-Position: refs/heads/master@{#32668}

Powered by Google App Engine
This is Rietveld 408576698