Fix window rect for plugins to map up to the root frame.

Fix window rect for plugins to map up to the root frame.

BUG=555381
Committed: https://crrev.com/8733d815f9fc2b7c4025f695a4ffa320df88c421
Cr-Commit-Position: refs/heads/master@{#364005}

[chrishtr, 2015-12-08 23:52:15]

Description was changed from

==========
none


none

BUG=
==========

to

==========
Fix window rect for plugins to map up to the root frame.

BUG=555381
==========

[chrishtr, 2015-12-08 23:53:15]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[chrishtr, 2015-12-08 23:53:16]

Turns out I was wrong in my previous patch. The code in LayoutPart which sets
the
position of a widget (including a plugin) is absolute within the local frame,
not in the
global page. (To get global page, you have to pass TraverseDocumentBoundaries).

[Xianzhu, 2015-12-09 00:13:09]

On 2015/12/08 23:53:16, chrishtr wrote:
> Turns out I was wrong in my previous patch. The code in LayoutPart which sets
> the
> position of a widget (including a plugin) is absolute within the local frame,
> not in the
> global page. (To get global page, you have to pass
TraverseDocumentBoundaries).

Which is the previous patch?

[chrishtr, 2015-12-09 00:14:39]

https://codereview.chromium.org/1466393003

[chrishtr, 2015-12-09 00:15:17]

On 2015/12/09 at 00:14:39, chrishtr wrote:
> https://codereview.chromium.org/1466393003

Wrong one sorry. This one: https://codereview.chromium.org/1457293003

[Xianzhu, 2015-12-09 00:16:47]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2015-12-09 00:16:47]

lgtm

[commit-bot: I haz the power, 2015-12-09 00:23:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1510083002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1510083002/1

[commit-bot: I haz the power, 2015-12-09 02:25:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 02:25:21]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2015-12-09 04:27:49]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-12-09 04:27:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/1510083002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-12-09 04:28:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1510083002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1510083002/20001

[commit-bot: I haz the power, 2015-12-09 08:22:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-09 08:23:27]

Description was changed from

==========
Fix window rect for plugins to map up to the root frame.

BUG=555381
==========

to

==========
Fix window rect for plugins to map up to the root frame.

BUG=555381

Committed: https://crrev.com/8733d815f9fc2b7c4025f695a4ffa320df88c421
Cr-Commit-Position: refs/heads/master@{#364005}
==========

[commit-bot: I haz the power, 2015-12-09 08:23:28]

Patchset 2 (id:??) landed as
https://crrev.com/8733d815f9fc2b7c4025f695a4ffa320df88c421
Cr-Commit-Position: refs/heads/master@{#364005}