Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1457293003: Adjust windowRect of plugins for root frame scrolling. (Closed)

Created:
5 years, 1 month ago by chrishtr
Modified:
5 years, 1 month ago
Reviewers:
Xianzhu
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust windowRect of plugins for root frame scrolling. BUG=553905 Committed: https://crrev.com/78fc076e1f00cdea94417097e95f64c3388ebf8f Cr-Commit-Position: refs/heads/master@{#360658}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/plugins/webview-plugin-scroll.html View 1 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/plugins/webview-plugin-scroll-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/plugins/webview-plugin-scroll-expected.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
chrishtr
5 years, 1 month ago (2015-11-19 19:10:29 UTC) #3
Xianzhu
lgtm
5 years, 1 month ago (2015-11-19 19:35:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457293003/20001
5 years, 1 month ago (2015-11-19 19:35:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 21:07:04 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 21:08:10 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/78fc076e1f00cdea94417097e95f64c3388ebf8f
Cr-Commit-Position: refs/heads/master@{#360658}

Powered by Google App Engine
This is Rietveld 408576698