third_party/WebKit/Source/web/WebPluginContainerImpl.cpp - Issue 1510083002: Fix window rect for plugins to map up to the root frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

Issue 1510083002: Fix window rect for plugins to map up to the root frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

index 8de3047c10d96c68b74d0f0b2b763c3dd0bfaafa..da5a6a2cecbc3f6ec6983bf977aa82018ecd6355 100644

--- a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

@@ -953,7 +953,7 @@ void WebPluginContainerImpl::computeClipRectsForPlugin(

// The frameRect is already in absolute space, except for scrolling of the root frame.

windowRect = frameRect();

- windowRect.moveBy(roundedIntPoint(-rootView->viewRect().location()));

+ windowRect = enclosingIntRect(m_element->document().view()->layoutView()->localToAbsoluteQuad(FloatQuad(FloatRect(frameRect())), TraverseDocumentBoundaries).boundingBox());

clippedLocalRect = enclosingIntRect(unclippedAbsoluteRect);

unclippedIntLocalRect = clippedLocalRect;

« no previous file with comments | « third_party/WebKit/LayoutTests/plugins/webview-plugin-nested-iframe-scroll-expected.txt ('k') | no next file » | no next file with comments »