Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 151003010: Merge 250273 "cc: Prevent usage of rasterize on-demand with dele..." (Closed)

Created:
6 years, 10 months ago by reveman
Modified:
6 years, 10 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Merge 250273 "cc: Prevent usage of rasterize on-demand with dele..." > cc: Prevent usage of rasterize on-demand with delegating renderer. > > PictureDrawQuads are not yet supported by the delegating renderer. > Generating this type of quads for on-demand raster of tiles cause > invalid IPC to be sent to the parent compositor and the renderer > to be killed. > > This makes us activate with low-res or checkerboard tiles until > PictureDrawQuads are properly supported by the delegating renderer. > > BUG=340695 > TEST=cc_unittests --gtest_filter=*RasterizeOnDemand* > > Review URL: https://codereview.chromium.org/157743007 TBR=reveman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -23 lines) Patch
M cc/output/delegating_renderer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/output/renderer.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/renderer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/output/software_renderer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/resources/tile_manager.h View 3 chunks +5 lines, -1 line 0 comments Download
M cc/resources/tile_manager.cc View 6 chunks +10 lines, -5 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 5 chunks +51 lines, -6 lines 0 comments Download
M cc/test/fake_tile_manager.h View 2 chunks +5 lines, -1 line 0 comments Download
M cc/test/fake_tile_manager.cc View 3 chunks +20 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
reveman
6 years, 10 months ago (2014-02-13 00:44:15 UTC) #1
reveman
6 years, 10 months ago (2014-02-13 00:44:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r250869.

Powered by Google App Engine
This is Rietveld 408576698