cc: Prevent usage of rasterize on-demand with delegating renderer.

cc: Prevent usage of rasterize on-demand with delegating renderer.

PictureDrawQuads are not yet supported by the delegating renderer.
Generating this type of quads for on-demand raster of tiles cause
invalid IPC to be sent to the parent compositor and the renderer
to be killed.

This makes us activate with low-res or checkerboard tiles until
PictureDrawQuads are properly supported by the delegating renderer.

BUG=340695
TEST=cc_unittests --gtest_filter=*RasterizeOnDemand*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250273

[reveman, 2014-02-08 06:39:55]

Please take a look asap.

[danakj, 2014-02-10 16:39:43]

https://codereview.chromium.org/157743007/diff/1/cc/resources/tile_manager.cc
File cc/resources/tile_manager.cc (right):

https://codereview.chromium.org/157743007/diff/1/cc/resources/tile_manager.cc...
cc/resources/tile_manager.cc:315: bool allow_rasterize_on_demand =
How about setting allow_rasterize_on_demand = false here if
!use_rasterize_on_demand instead of checking it further down?

This would mean we return; early instead of continuing through the loop. Would
that work out?

https://codereview.chromium.org/157743007/diff/1/cc/trees/layer_tree_host.h
File cc/trees/layer_tree_host.h (right):

https://codereview.chromium.org/157743007/diff/1/cc/trees/layer_tree_host.h#n...
cc/trees/layer_tree_host.h:83: bool allow_rasterize_on_demand;
Does the main thread need to know about this? I don't think it does, so we don't
need to add it here.

[reveman, 2014-02-10 17:16:03]

https://codereview.chromium.org/157743007/diff/1/cc/resources/tile_manager.cc
File cc/resources/tile_manager.cc (right):

https://codereview.chromium.org/157743007/diff/1/cc/resources/tile_manager.cc...
cc/resources/tile_manager.cc:315: bool allow_rasterize_on_demand =
On 2014/02/10 16:39:43, danakj wrote:
> How about setting allow_rasterize_on_demand = false here if
> !use_rasterize_on_demand instead of checking it further down?
> 
> This would mean we return; early instead of continuing through the loop. Would
> that work out?

That doesn't work as the result would be that we never activate.

https://codereview.chromium.org/157743007/diff/1/cc/trees/layer_tree_host.h
File cc/trees/layer_tree_host.h (right):

https://codereview.chromium.org/157743007/diff/1/cc/trees/layer_tree_host.h#n...
cc/trees/layer_tree_host.h:83: bool allow_rasterize_on_demand;
On 2014/02/10 16:39:43, danakj wrote:
> Does the main thread need to know about this? I don't think it does, so we
don't
> need to add it here.

Correct. Fixed in latest patch.

[danakj, 2014-02-10 17:46:22]

LGTM, but is there a test we can add for this?

https://codereview.chromium.org/157743007/diff/1/cc/resources/tile_manager.cc
File cc/resources/tile_manager.cc (right):

https://codereview.chromium.org/157743007/diff/1/cc/resources/tile_manager.cc...
cc/resources/tile_manager.cc:315: bool allow_rasterize_on_demand =
On 2014/02/10 17:16:14, David Reveman wrote:
> On 2014/02/10 16:39:43, danakj wrote:
> > How about setting allow_rasterize_on_demand = false here if
> > !use_rasterize_on_demand instead of checking it further down?
> > 
> > This would mean we return; early instead of continuing through the loop.
Would
> > that work out?
> 
> That doesn't work as the result would be that we never activate.

Oh.. right.. I see the comment now.

[piman, 2014-02-10 19:23:29]

lgtm

[reveman, 2014-02-10 21:04:05]

Added some unit tests.

[reveman, 2014-02-10 21:04:19]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-02-10 21:05:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/157743007/240001

[danakj, 2014-02-10 21:08:16]

Thanks for the tests LGTM

[commit-bot: I haz the power, 2014-02-10 22:51:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/157743007/240001

[commit-bot: I haz the power, 2014-02-10 23:46:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/157743007/240001

[commit-bot: I haz the power, 2014-02-11 01:56:39]

Change committed as 250273