Lazily load API schemas from resource files and convert all APIs to features

chrome/common/extensions/features/simple_feature.cc

Index: chrome/common/extensions/features/simple_feature.cc
diff --git a/chrome/common/extensions/features/simple_feature.cc b/chrome/common/extensions/features/simple_feature.cc
index 2d20787282b4ab89a20f2fff0c67849f45753734..27dd0550f1d1ed4803018b4ae16abf1f57ce9278 100644
--- a/chrome/common/extensions/features/simple_feature.cc
+++ b/chrome/common/extensions/features/simple_feature.cc
@@ -141,6 +141,7 @@ void ParseURLPatterns(const DictionaryValue* value,
                       URLPatternSet* set) {
   const ListValue* matches = NULL;
   if (value->GetList(key, &matches)) {
+    set->ClearPatterns();

[not at google - send to devlin, 2013/05/23 00:09:40]

is this cleanup or was there a bug?

[cduvall, 2013/05/24 03:13:49]

There could have been a bug when I was parsing the child after the parent, to
make sure the child feature would overwrite the parent URL patterns. This
matches what the other Parse* functions do.

     for (size_t i = 0; i < matches->GetSize(); ++i) {
       std::string pattern;
       CHECK(matches->GetString(i, &pattern));
@@ -423,6 +424,10 @@ bool SimpleFeature::IsInternal() const {
   return false;
 }
 
+bool SimpleFeature::HasParent() const {
+  return false;
+}
+
 bool SimpleFeature::IsIdInWhitelist(const std::string& extension_id) const {
   // Belt-and-suspenders philosophy here. We should be pretty confident by this
   // point that we've validated the extension ID format, but in case something