chrome/common/extensions/features/feature_provider.h - Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/feature_provider.h

Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: optimize and "parent" property Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/features/complex_feature.cc ('K') | « chrome/common/extensions/features/feature.h ('k') | chrome/common/extensions/features/simple_feature.h » ('j') | chrome/common/extensions/features/simple_feature.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/feature_provider.h

diff --git a/chrome/common/extensions/features/feature_provider.h b/chrome/common/extensions/features/feature_provider.h

index 8a211c909f2a9ca6ae15ad3d490a69bbb9d9e7ec..3debcd5f60d842c7afd24b6fdcdde13799400d70 100644

--- a/chrome/common/extensions/features/feature_provider.h

+++ b/chrome/common/extensions/features/feature_provider.h

@@ -21,7 +21,10 @@ class FeatureProvider {

virtual Feature* GetFeature(const std::string& name) = 0;

// Returns all features described by this instance.

- virtual std::set<std::string> GetAllFeatureNames() = 0;

+ virtual std::vector<std::string> GetAllFeatureNames() = 0;

+ // Returns all features described by this instance that do not have a parent.

+ virtual std::vector<std::string> GetAllTopLevelFeatureNames() = 0;

not at google - send to devlin 2013/05/23 00:09:40 would probably be simpler if we let callers filter

cduvall 2013/05/24 03:13:49 Done.

};

} // namespace extensions