Lazily load API schemas from resource files and convert all APIs to features

chrome/common/extensions/features/simple_feature.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/features/simple_feature.h"
 
 #include <map>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 123 matching lines @@
     ParseEnum(*iter, &enum_value, mapping);
     enum_set->insert(enum_value);
   }
 }
 
 void ParseURLPatterns(const DictionaryValue* value,
                       const std::string& key,
                       URLPatternSet* set) {
   const ListValue* matches = NULL;
   if (value->GetList(key, &matches)) {
+    set->ClearPatterns();

[not at google - send to devlin, 2013/05/23 00:09:40]

is this cleanup or was there a bug?

[cduvall, 2013/05/24 03:13:49]

There could have been a bug when I was parsing the child after the parent, to
make sure the child feature would overwrite the parent URL patterns. This
matches what the other Parse* functions do.

     for (size_t i = 0; i < matches->GetSize(); ++i) {
       std::string pattern;
       CHECK(matches->GetString(i, &pattern));
       set->AddPattern(URLPattern(URLPattern::SCHEME_ALL, pattern));
     }
   }
 }
 
 // Gets a human-readable name for the given extension type.
 std::string GetDisplayTypeName(Manifest::Type type) {
@@ skipping 262 matching lines @@
 
 std::set<Feature::Context>* SimpleFeature::GetContexts() {
   return &contexts_;
 }
 
 bool SimpleFeature::IsInternal() const {
   NOTREACHED();
   return false;
 }
 
+bool SimpleFeature::HasParent() const {
+  return false;
+}
+
 bool SimpleFeature::IsIdInWhitelist(const std::string& extension_id) const {
   // Belt-and-suspenders philosophy here. We should be pretty confident by this
   // point that we've validated the extension ID format, but in case something
   // slips through, we avoid a class of attack where creative ID manipulation
   // leads to hash collisions.
   if (extension_id.length() != 32)  // 128 bits / 4 = 32 mpdecimal characters
     return false;
 
   if (whitelist_.find(extension_id) != whitelist_.end() ||
       whitelist_.find(HashExtensionId(extension_id)) != whitelist_.end())
     return true;
 
   return false;
 }
 
 }  // namespace extensions