Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1508853008: chrome: rename more wrench/Wrench occurrencies to appMenu/AppMenu (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
CC:
chromium-reviews, extensions-reviews_chromium.org, rouslan+autofill_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, Ben Goodger (Google), sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome: rename more wrench/Wrench occurrencies to appMenu/AppMenu The wrench icon has been gone for a long time now, the new icon is a sideways ellipsis called browser_tools. And it is now known by app menu. BUG=None R=pkasting@chromium.org,avi@chromium.org TBR=thestig@chromium.org Committed: https://crrev.com/5c5bc4d2d45110528b5c04c40e4fc316cf4a8de9 Cr-Commit-Position: refs/heads/master@{#364349}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix updateAppButtonSeverity and rewrap + rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -298 lines) Patch
A + chrome/app/nibs/AppMenu.xib View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/nibs/Toolbar.xib View 1 chunk +1 line, -1 line 0 comments Download
D chrome/app/nibs/WrenchMenu.xib View 1 chunk +0 lines, -191 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/chrome_pages.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_command_handler.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm View 7 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/global_error_bubble_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/global_error_bubble_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/menu_button.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 15 chunks +31 lines, -31 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/toolbar/app_menu_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_nibs.gypi View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/localized_error.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
tfarina
PTAL!
5 years ago (2015-12-09 12:59:04 UTC) #1
Avi (use Gerrit)
lgtm lookin' good.
5 years ago (2015-12-09 15:27:21 UTC) #2
Peter Kasting
LGTM https://codereview.chromium.org/1508853008/diff/1/chrome/browser/ui/cocoa/menu_button.h File chrome/browser/ui/cocoa/menu_button.h (right): https://codereview.chromium.org/1508853008/diff/1/chrome/browser/ui/cocoa/menu_button.h#newcode20 chrome/browser/ui/cocoa/menu_button.h:20: // used for the App menu, for example. ...
5 years ago (2015-12-09 21:31:17 UTC) #3
tfarina
TBRing Lei for the chrome/ changes. https://codereview.chromium.org/1508853008/diff/1/chrome/browser/ui/cocoa/menu_button.h File chrome/browser/ui/cocoa/menu_button.h (right): https://codereview.chromium.org/1508853008/diff/1/chrome/browser/ui/cocoa/menu_button.h#newcode20 chrome/browser/ui/cocoa/menu_button.h:20: // used for ...
5 years ago (2015-12-10 13:36:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508853008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508853008/20001
5 years ago (2015-12-10 13:37:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 14:19:53 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5c5bc4d2d45110528b5c04c40e4fc316cf4a8de9 Cr-Commit-Position: refs/heads/master@{#364349}
5 years ago (2015-12-10 14:20:31 UTC) #13
Lei Zhang
5 years ago (2015-12-10 18:50:21 UTC) #14
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698