chrome/browser/ui/cocoa/browser_window_command_handler.mm - Issue 1508853008: chrome: rename more wrench/Wrench occurrencies to appMenu/AppMenu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_command_handler.mm

Issue 1508853008: chrome: rename more wrench/Wrench occurrencies to appMenu/AppMenu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix updateAppButtonSeverity and rewrap + rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_command_handler.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_command_handler.mm b/chrome/browser/ui/cocoa/browser_window_command_handler.mm

index f30b90d2d31ff9444ae7b475456f543c37482422..3bbdb3bda9c2a340d9a8c5d6c58c22a1790a7773 100644

--- a/chrome/browser/ui/cocoa/browser_window_command_handler.mm

+++ b/chrome/browser/ui/cocoa/browser_window_command_handler.mm

@@ -184,8 +184,8 @@ Browser* FindBrowserForSender(id sender, NSWindow* window) {

case IDC_BOOKMARK_PAGE: {

// Extensions have the ability to hide the bookmark page menu item.

// This only affects the bookmark page menu item under the main menu.

- // The bookmark page menu item under the wrench menu has its

- // visibility controlled by AppMenuModel.

+ // The bookmark page menu item under the app menu has its visibility

+ // controlled by AppMenuModel.

bool shouldHide =

chrome::ShouldRemoveBookmarkThisPageUI(browser->profile());

NSMenuItem* menuItem = base::mac::ObjCCast<NSMenuItem>(item);

@@ -195,7 +195,7 @@ Browser* FindBrowserForSender(id sender, NSWindow* window) {