chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm - Issue 1508853008: chrome: rename more wrench/Wrench occurrencies to appMenu/AppMenu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm

Issue 1508853008: chrome: rename more wrench/Wrench occurrencies to appMenu/AppMenu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix updateAppButtonSeverity and rewrap + rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h ('k') | chrome/browser/ui/cocoa/toolbar/toolbar_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm

index e66f5ff6d8f97b667d4e6fbdb4ee62c5c5de9532..5acb2d8a6c6a9c61f218bd5c0a975c0ec7964740 100644

--- a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm

@@ -36,11 +36,11 @@ void PerformClose(OneClickSigninBubbleController* controller) {

NSWindow* parentWindow = [controller window];

- // Set the anchor point to right below the wrench menu.

- NSView* wrenchButton = [[controller toolbarController] wrenchButton];

- const NSRect bounds = [wrenchButton bounds];

+ // Set the anchor point to right below the app menu.

+ NSView* appMenuButton = [[controller toolbarController] appMenuButton];

+ const NSRect bounds = [appMenuButton bounds];

NSPoint anchorPoint = NSMakePoint(NSMidX(bounds), NSMaxY(bounds));

- anchorPoint = [wrenchButton convertPoint:anchorPoint toView:nil];

+ anchorPoint = [appMenuButton convertPoint:anchorPoint toView:nil];

anchorPoint = [parentWindow convertBaseToScreen:anchorPoint];

// Create an empty window into which content is placed.