Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1508713003: Add deprecation message for CSSXGetComputedStyleQueries. (Closed)

Created:
5 years ago by suzyh_UTC10 (ex-contributor)
Modified:
5 years ago
Reviewers:
Timothy Loh, esprehn
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add deprecation message for CSSXGetComputedStyleQueries. This patch adds a deprecation message for getComputedStyle(e).css* as per https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/SX901460nbI. BUG=413205 Committed: https://crrev.com/47e71df82119e855e8c94d2d05e3890a7df3e0e1 Cr-Commit-Position: refs/heads/master@{#365081}

Patch Set 1 #

Patch Set 2 : Response to review comments, fix affected tests #

Messages

Total messages: 17 (6 generated)
suzyh_UTC10 (ex-contributor)
5 years ago (2015-12-08 01:42:13 UTC) #2
Timothy Loh
On 2015/12/08 01:42:13, suzyh wrote: Can we have a test that this warning actually fires? ...
5 years ago (2015-12-08 07:04:12 UTC) #3
suzyh_UTC10 (ex-contributor)
On 2015/12/08 at 07:04:12, timloh wrote: > On 2015/12/08 01:42:13, suzyh wrote: > > Can ...
5 years ago (2015-12-14 01:00:39 UTC) #4
Timothy Loh
On 2015/12/14 01:00:39, suzyh wrote: > On 2015/12/08 at 07:04:12, timloh wrote: > > On ...
5 years ago (2015-12-14 02:05:12 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508713003/20001
5 years ago (2015-12-14 02:28:52 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-14 03:44:37 UTC) #9
suzyh_UTC10 (ex-contributor)
+esprehn for OWNERS approval for third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
5 years ago (2015-12-14 03:59:02 UTC) #11
esprehn
lgtm
5 years ago (2015-12-14 06:57:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508713003/20001
5 years ago (2015-12-14 20:01:58 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-14 20:17:30 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-14 20:18:24 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47e71df82119e855e8c94d2d05e3890a7df3e0e1
Cr-Commit-Position: refs/heads/master@{#365081}

Powered by Google App Engine
This is Rietveld 408576698