third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp - Issue 1508713003: Add deprecation message for CSSXGetComputedStyleQueries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 1508713003: Add deprecation message for CSSXGetComputedStyleQueries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to review comments, fix affected tests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/CSSStyleDeclaration/script-tests/css-properties-case-sensitive.js ('k') | third_party/WebKit/Source/core/frame/UseCounter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

index fb9dc2d268d490ac3aa256844736a8fdbc812902..a6c43d71c1a9e3b48cd470a83fc501abb64de952 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

@@ -96,7 +96,7 @@ static CSSPropertyID parseCSSPropertyID(v8::Isolate* isolate, const String& prop

i += 3;

// getComputedStyle(elem).cssX is a non-standard behaviour

// Measure this behaviour as CSSXGetComputedStyleQueries.

- UseCounter::countIfNotPrivateScript(isolate, callingExecutionContext(isolate), UseCounter::CSSXGetComputedStyleQueries);

+ UseCounter::countDeprecationIfNotPrivateScript(isolate, callingExecutionContext(isolate), UseCounter::CSSXGetComputedStyleQueries);

} else if (hasCSSPropertyNamePrefix(propertyName, "webkit"))

builder.append('-');

else if (isASCIIUpper(propertyName[0]))