Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Side by Side Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 1508713003: Add deprecation message for CSSXGetComputedStyleQueries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review comments, fix affected tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 939 matching lines...) Expand 10 before | Expand all | Expand 10 after
950 950
951 case V8SVGElement_OffsetWidth_AttributeGetter: 951 case V8SVGElement_OffsetWidth_AttributeGetter:
952 return "'SVGElement.offsetWidth' is deprecated and will be removed in M5 0, around April 2016. See https://www.chromestatus.com/features/5724912467574784 for more details."; 952 return "'SVGElement.offsetWidth' is deprecated and will be removed in M5 0, around April 2016. See https://www.chromestatus.com/features/5724912467574784 for more details.";
953 953
954 case V8SVGElement_OffsetHeight_AttributeGetter: 954 case V8SVGElement_OffsetHeight_AttributeGetter:
955 return "'SVGElement.offsetHeight' is deprecated and will be removed in M 50, around April 2016. See https://www.chromestatus.com/features/572491246757478 4 for more details."; 955 return "'SVGElement.offsetHeight' is deprecated and will be removed in M 50, around April 2016. See https://www.chromestatus.com/features/572491246757478 4 for more details.";
956 956
957 case MediaStreamTrackGetSources: 957 case MediaStreamTrackGetSources:
958 return "MediaStreamTrack.getSources is deprecated. See https://www.chrom estatus.com/feature/4765305641369600 for more details."; 958 return "MediaStreamTrack.getSources is deprecated. See https://www.chrom estatus.com/feature/4765305641369600 for more details.";
959 959
960 case CSSXGetComputedStyleQueries:
961 return "'getComputedStyle(e).cssXx' (except .cssFloat) is deprecated and will be removed in M50, around April 2016. Please use 'getComputedStyle(e).xx' instead.";
962
960 // Features that aren't deprecated don't have a deprecation message. 963 // Features that aren't deprecated don't have a deprecation message.
961 default: 964 default:
962 return String(); 965 return String();
963 } 966 }
964 } 967 }
965 968
966 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 969 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
967 { 970 {
968 ASSERT(feature >= firstCSSProperty); 971 ASSERT(feature >= firstCSSProperty);
969 ASSERT(feature <= lastUnresolvedCSSProperty); 972 ASSERT(feature <= lastUnresolvedCSSProperty);
(...skipping 27 matching lines...) Expand all
997 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 1000 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
998 { 1001 {
999 // FIXME: We may want to handle stylesheets that have multiple owners 1002 // FIXME: We may want to handle stylesheets that have multiple owners
1000 // https://crbug.com/242125 1003 // https://crbug.com/242125
1001 if (sheetContents && sheetContents->hasSingleOwnerNode()) 1004 if (sheetContents && sheetContents->hasSingleOwnerNode())
1002 return getFrom(sheetContents->singleOwnerDocument()); 1005 return getFrom(sheetContents->singleOwnerDocument());
1003 return 0; 1006 return 0;
1004 } 1007 }
1005 1008
1006 } // namespace blink 1009 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698