Oilpan: remove unnecessary MultisamplingChangedObserver unregistration.

Oilpan: remove unnecessary MultisamplingChangedObserver unregistration.

As the Page keeps weak references to its MultisamplingChangedObservers,
there is no need to explicitly unregister upon finalization of
WebGLRenderingContextBase. It will already have been removed by
weak processing.

That unregistration step was made safe by virtue of the context object
being eagerly finalized.

R=haraken
BUG=

Committed: https://crrev.com/c8060f98801b3a49de3716e3e9272fb43cbdf71f
Cr-Commit-Position: refs/heads/master@{#363489}

[sof, 2015-12-07 12:05:56]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[sof, 2015-12-07 12:06:18]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-12-07 12:06:19]

please take a look.

[commit-bot: I haz the power, 2015-12-07 12:07:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508673002/1

[haraken, 2015-12-07 12:07:45]

LGTM

[sof, 2015-12-07 12:16:57]

I'm inclined to not make Page::removeMultisamplingChangedObserver() available
with Oilpan, as long as there's no current need to explicitly unregister an
observer before it is finalized. Worth doing?

[sof, 2015-12-07 12:28:41]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[sof, 2015-12-07 12:28:54]

On 2015/12/07 12:16:57, sof wrote:
> I'm inclined to not make Page::removeMultisamplingChangedObserver() available
> with Oilpan, as long as there's no current need to explicitly unregister an
> observer before it is finalized. Worth doing?

Done.

[commit-bot: I haz the power, 2015-12-07 12:29:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508673002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508673002/20001

[sof, 2015-12-07 12:38:36]

Description was changed from

==========
Oilpan: remove unnecessary MultisamplingChangedObserver unregistration.

As the Page keeps weak references to its MultisamplingChangedObservers,
there is no need to explicitly unregister upon finalization of
WebGLRenderingContextBase. It will already have been removed by
weak processing.

That unregistration step was made safe by virtue of the context object
being eagerly finalized.

R=
BUG=
==========

to

==========
Oilpan: remove unnecessary MultisamplingChangedObserver unregistration.

As the Page keeps weak references to its MultisamplingChangedObservers,
there is no need to explicitly unregister upon finalization of
WebGLRenderingContextBase. It will already have been removed by
weak processing.

That unregistration step was made safe by virtue of the context object
being eagerly finalized.

R=haraken
BUG=
==========

[haraken, 2015-12-07 14:23:25]

Looks nicer :)

[commit-bot: I haz the power, 2015-12-07 15:02:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 15:02:01]

Dry run: This issue passed the CQ dry run.

[sof, 2015-12-07 15:50:50]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-12-07 15:50:50]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1508673002/#ps20001
(title: "only provide removeMultisamplingChangedObserver non-Oilpan")

[commit-bot: I haz the power, 2015-12-07 15:51:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508673002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508673002/20001

[commit-bot: I haz the power, 2015-12-07 15:57:00]

Description was changed from

==========
Oilpan: remove unnecessary MultisamplingChangedObserver unregistration.

As the Page keeps weak references to its MultisamplingChangedObservers,
there is no need to explicitly unregister upon finalization of
WebGLRenderingContextBase. It will already have been removed by
weak processing.

That unregistration step was made safe by virtue of the context object
being eagerly finalized.

R=haraken
BUG=
==========

to

==========
Oilpan: remove unnecessary MultisamplingChangedObserver unregistration.

As the Page keeps weak references to its MultisamplingChangedObservers,
there is no need to explicitly unregister upon finalization of
WebGLRenderingContextBase. It will already have been removed by
weak processing.

That unregistration step was made safe by virtue of the context object
being eagerly finalized.

R=haraken
BUG=
==========

[commit-bot: I haz the power, 2015-12-07 15:57:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-07 15:57:54]

Description was changed from

==========
Oilpan: remove unnecessary MultisamplingChangedObserver unregistration.

As the Page keeps weak references to its MultisamplingChangedObservers,
there is no need to explicitly unregister upon finalization of
WebGLRenderingContextBase. It will already have been removed by
weak processing.

That unregistration step was made safe by virtue of the context object
being eagerly finalized.

R=haraken
BUG=
==========

to

==========
Oilpan: remove unnecessary MultisamplingChangedObserver unregistration.

As the Page keeps weak references to its MultisamplingChangedObservers,
there is no need to explicitly unregister upon finalization of
WebGLRenderingContextBase. It will already have been removed by
weak processing.

That unregistration step was made safe by virtue of the context object
being eagerly finalized.

R=haraken
BUG=

Committed: https://crrev.com/c8060f98801b3a49de3716e3e9272fb43cbdf71f
Cr-Commit-Position: refs/heads/master@{#363489}
==========

[commit-bot: I haz the power, 2015-12-07 15:57:55]

Patchset 2 (id:??) landed as
https://crrev.com/c8060f98801b3a49de3716e3e9272fb43cbdf71f
Cr-Commit-Position: refs/heads/master@{#363489}