third_party/WebKit/Source/core/page/Page.cpp - Issue 1508673002: Oilpan: remove unnecessary MultisamplingChangedObserver unregistration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 1508673002: Oilpan: remove unnecessary MultisamplingChangedObserver unregistration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: only provide removeMultisamplingChangedObserver non-Oilpan Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/Page.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/Page.cpp

diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp

index d06a8e15c13590fed7c6d6089c932b0b941ddc11..037913400a533a017c86ab3ddb1bc1688c07e2ea 100644

--- a/third_party/WebKit/Source/core/page/Page.cpp

+++ b/third_party/WebKit/Source/core/page/Page.cpp

@@ -389,10 +389,13 @@ void Page::addMultisamplingChangedObserver(MultisamplingChangedObserver* observe

m_multisamplingChangedObservers.add(observer);

}

+// For Oilpan, unregistration is handled by the GC and weak references.

+#if !ENABLE(OILPAN)

void Page::removeMultisamplingChangedObserver(MultisamplingChangedObserver* observer)

{

m_multisamplingChangedObservers.remove(observer);

}

+#endif

void Page::settingsChanged(SettingsDelegate::ChangeType changeType)

{