Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 1508673002: Oilpan: remove unnecessary MultisamplingChangedObserver unregistration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: only provide removeMultisamplingChangedObserver non-Oilpan Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 bool Page::isCursorVisible() const 382 bool Page::isCursorVisible() const
383 { 383 {
384 return m_isCursorVisible && settings().deviceSupportsMouse(); 384 return m_isCursorVisible && settings().deviceSupportsMouse();
385 } 385 }
386 386
387 void Page::addMultisamplingChangedObserver(MultisamplingChangedObserver* observe r) 387 void Page::addMultisamplingChangedObserver(MultisamplingChangedObserver* observe r)
388 { 388 {
389 m_multisamplingChangedObservers.add(observer); 389 m_multisamplingChangedObservers.add(observer);
390 } 390 }
391 391
392 // For Oilpan, unregistration is handled by the GC and weak references.
393 #if !ENABLE(OILPAN)
392 void Page::removeMultisamplingChangedObserver(MultisamplingChangedObserver* obse rver) 394 void Page::removeMultisamplingChangedObserver(MultisamplingChangedObserver* obse rver)
393 { 395 {
394 m_multisamplingChangedObservers.remove(observer); 396 m_multisamplingChangedObservers.remove(observer);
395 } 397 }
398 #endif
396 399
397 void Page::settingsChanged(SettingsDelegate::ChangeType changeType) 400 void Page::settingsChanged(SettingsDelegate::ChangeType changeType)
398 { 401 {
399 switch (changeType) { 402 switch (changeType) {
400 case SettingsDelegate::StyleChange: 403 case SettingsDelegate::StyleChange:
401 setNeedsRecalcStyleInAllFrames(); 404 setNeedsRecalcStyleInAllFrames();
402 break; 405 break;
403 case SettingsDelegate::ViewportDescriptionChange: 406 case SettingsDelegate::ViewportDescriptionChange:
404 if (mainFrame() && mainFrame()->isLocalFrame()) 407 if (mainFrame() && mainFrame()->isLocalFrame())
405 deprecatedLocalMainFrame()->document()->updateViewportDescription(); 408 deprecatedLocalMainFrame()->document()->updateViewportDescription();
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 { 592 {
590 } 593 }
591 594
592 Page::PageClients::~PageClients() 595 Page::PageClients::~PageClients()
593 { 596 {
594 } 597 }
595 598
596 template class CORE_TEMPLATE_EXPORT WillBeHeapSupplement<Page>; 599 template class CORE_TEMPLATE_EXPORT WillBeHeapSupplement<Page>;
597 600
598 } // namespace blink 601 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698